Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200910140415.1132266-1-yanaijie@huawei.com>
In-Reply-To: <20200910140415.1132266-1-yanaijie@huawei.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Sun, 20 Sep 2020 22:19:37 +0200
Message-ID: <CAJKOXPcsrL2T9EmiSnOhrC5Lh+ZM=nY4Go52cVDv1S6wxn5DHQ@mail.gmail.com>
Subject: Re: [PATCH] soc: fsl: dpio: remove set but not used 'addr_cena'
To:     Jason Yan <yanaijie@huawei.com>
Cc:     Roy.Pledge@nxp.com, leoyang.li@nxp.com, youri.querry_1@nxp.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org,
        Hulk Robot <hulkci@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 10 Sep 2020 at 16:57, Jason Yan <yanaijie@huawei.com> wrote:
>
> This addresses the following gcc warning with "make W=3D1":
>
> drivers/soc/fsl/dpio/qbman-portal.c: In function
> =E2=80=98qbman_swp_enqueue_multiple_direct=E2=80=99:
> drivers/soc/fsl/dpio/qbman-portal.c:650:11: warning: variable
> =E2=80=98addr_cena=E2=80=99 set but not used [-Wunused-but-set-variable]
>   650 |  uint64_t addr_cena;
>       |           ^~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

This was already reported:
Reported-by: kernel test robot <lkp@intel.com>
https://lkml.org/lkml/2020/6/12/290

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

> ---
>  drivers/soc/fsl/dpio/qbman-portal.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/dpio/qbman-portal.c b/drivers/soc/fsl/dpio/q=
bman-portal.c
> index 0ab85bfb116f..659b4a570d5b 100644
> --- a/drivers/soc/fsl/dpio/qbman-portal.c
> +++ b/drivers/soc/fsl/dpio/qbman-portal.c
> @@ -647,7 +647,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_sw=
p *s,
>         const uint32_t *cl =3D (uint32_t *)d;
>         uint32_t eqcr_ci, eqcr_pi, half_mask, full_mask;
>         int i, num_enqueued =3D 0;
> -       uint64_t addr_cena;
>
>         spin_lock(&s->access_spinlock);
>         half_mask =3D (s->eqcr.pi_ci_mask>>1);
> @@ -701,7 +700,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_sw=
p *s,
>
>         /* Flush all the cacheline without load/store in between */
>         eqcr_pi =3D s->eqcr.pi;
> -       addr_cena =3D (size_t)s->addr_cena;
>         for (i =3D 0; i < num_enqueued; i++)
>                 eqcr_pi++;
>         s->eqcr.pi =3D eqcr_pi & full_mask;
> --
> 2.25.4
>