Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Hongbo Wang <hongbo.wang@nxp.com>
To:     David Miller <davem@davemloft.net>
CC:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>, Po Liu <po.liu@nxp.com>,
        Mingkai Hu <mingkai.hu@nxp.com>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Leo Li <leoyang.li@nxp.com>, "andrew@lunn.ch" <andrew@lunn.ch>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "idosch@idosch.org" <idosch@idosch.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "nikolay@cumulusnetworks.com" <nikolay@cumulusnetworks.com>,
        "roopa@cumulusnetworks.com" <roopa@cumulusnetworks.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "horatiu.vultur@microchip.com" <horatiu.vultur@microchip.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "ivecera@redhat.com" <ivecera@redhat.com>
Subject: RE: [EXT] Re: [PATCH v6 0/3] Add 802.1AD protocol support for dsa
 switch and ocelot driver
Thread-Topic: [EXT] Re: [PATCH v6 0/3] Add 802.1AD protocol support for dsa
 switch and ocelot driver
Thread-Index: AQHWjA4oKTirJX0x8UaU4z1kN1uF0qlvHTqAgANNP1A=
Date:   Mon, 21 Sep 2020 03:05:22 +0000
Message-ID: <VI1PR04MB5677B72C6AFFB0E97357C94AE13A0@VI1PR04MB5677.eurprd04.prod.outlook.com>
References: <20200916094845.10782-1-hongbo.wang@nxp.com>
 <20200918.172025.962077344132523092.davem@davemloft.net>
In-Reply-To: <20200918.172025.962077344132523092.davem@davemloft.net>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ca796846-e870-4897-a76b-08d85ddb2e5d
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 03:05:22.8246
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JjhshqdHbUDAk/7L3fiS+IL/1E5eAClFQPQz4WDpEx6siBRZACa2HlAauU+WVxMZCqxTT4YCtyV0TMPJ5C9Epg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4111
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> You're going to have to update every single SWITCHDEV_PORT_ADD_OBJ
> handler and subsequent helpers to check the validate the protocol value.
>=20
> You also are going to have to make sure that every instantiated
> switchdev_obj_port_vlan object initializes the vlan protocol field proper=
ly.
>=20
> Basically, now that this structure has a new member, everything that oper=
ates
> on that object must be updated to handle the new protocol value.
>=20
> And I do mean everything.
>=20
> You can't just add the protocol handling to the locations you care about =
for
> bridging and DSA.
>=20
> You also have to more fully address the feedback given by Vladimir in pat=
ch #3.
> Are the expectations on the user side a Linux based expectation, or one s=
pecific
> about how this ASIC is expected to behave by default.  It is very unclear=
 what
> you are talking about when you say customer and ISP etc.
>=20

Hi David,

Thanks for your comments.

I understand your concerns, I will review the code.
Generally, the packets from customer port will have only C-TAG, but the pac=
kets form ISP port will have both S-TAG and C-TAG. For ocelot switch, these=
 two ports have different register config.


Thanks
hongbo