Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2868775pxk; Sun, 20 Sep 2020 21:29:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfqgEQ6xQ8FtKmY8/io4dZXbnV4G3ZL8GqURqq1JLCCFYXaLsKw9qDIMHnXRL9bheUyZ+o X-Received: by 2002:a17:906:d11a:: with SMTP id b26mr46369610ejz.191.1600662585050; Sun, 20 Sep 2020 21:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600662585; cv=none; d=google.com; s=arc-20160816; b=wAXeNrU+kdFjuR9Yp8n4OG4FXVmX/qAiwYprpDeDAZEF4JUAr6JaG8SusoZIFFyxRK ExoJhHH7CdFepWNfDan5SnO7xp+3wCWKx3aRYylu+kshz5B4vEZSQz2YuOoG8z+BU06g kuKGcxXCOn9u7vByRj2dGiD7eAIzIVTQbbIpSYPg8SLuFX0Zg5cSFun8wU1PvyuQLbku Of8afnmSkUxQ2X2OmmL78aMpjqiCl4vbUwUn0G21qpToanfmpvoZ6shmJMJZz2v5rDGW IIH4OHd25hj/uWNwTMddjnoCqZqJ32T70kTA4IcIfjJCuS3d1pK7Ml0usWJUdZ8OArRx nRuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=02v+joTGVNyiRzP9PzN0ngs8MwABhaoAMiiNPY9fJYQ=; b=gNJcWCIFKFxi6MLayunD81ooEEyRSVFk4vAtNKEQEoE0gO1RPk6x8qzAnSxGLprZ+Z Nefs+fxiYeAPN3GvGo2KPJZrRZ0MVL0PKxcCDDLjeAa0dw8vIEXHLW4TGqZl6nYLFHtg qc2ptlg9lAOsqXc1GwI66QEvim49F7BKIccPdPg5TxhAaHAzXpR8zbc9zzbwPYFcoi1H HynUgohSVawVdD3h7uNVXyKQzyUIaVam5B506xLdf8sugE0P5faJ5vQ3OCKgOBbnqH1u f6yMyBhI6lh+9eq4FMCj7k2cIaDjPx1awafJXZ1P5EUJ88XS4GpY6ELRLNRlzDY3dr3p 3YIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si2877712edq.536.2020.09.20.21.29.21; Sun, 20 Sep 2020 21:29:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726324AbgIUE2V (ORCPT + 99 others); Mon, 21 Sep 2020 00:28:21 -0400 Received: from verein.lst.de ([213.95.11.211]:38359 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbgIUE2U (ORCPT ); Mon, 21 Sep 2020 00:28:20 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 979FC68AFE; Mon, 21 Sep 2020 06:28:15 +0200 (CEST) Date: Mon, 21 Sep 2020 06:28:15 +0200 From: Christoph Hellwig To: Andy Lutomirski Cc: Al Viro , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Jens Axboe , Arnd Bergmann , David Howells , linux-arm-kernel , X86 ML , LKML , "open list:MIPS" , Parisc List , linuxppc-dev , linux-s390 , sparclinux , linux-block , Linux SCSI List , Linux FS Devel , linux-aio , io-uring@vger.kernel.org, linux-arch , Linux-MM , Network Development , keyrings@vger.kernel.org, LSM List Subject: Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag Message-ID: <20200921042815.GA16281@lst.de> References: <20200918124533.3487701-1-hch@lst.de> <20200918124533.3487701-2-hch@lst.de> <20200920151510.GS32101@casper.infradead.org> <20200920180742.GN3421308@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 20, 2020 at 12:14:49PM -0700, Andy Lutomirski wrote: > I wonder if this is really quite cast in stone. We could also have > FMODE_SHITTY_COMPAT and set that when a file like this is *opened* in > compat mode. Then that particular struct file would be read and > written using the compat data format. The change would be > user-visible, but the user that would see it would be very strange > indeed. > > I don't have a strong opinion as to whether that is better or worse > than denying io_uring access to these things, but at least it moves > the special case out of io_uring. open could have happened through an io_uring thread a well, so I don't see how this would do anything but move the problem to a different place. > > --Andy ---end quoted text---