Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2915873pxk; Sun, 20 Sep 2020 23:36:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHb4xpmZaZCiAMoaJar8FzJWJNC8tcb2W6bKs30eMFzZ5Ckz3qAbYpn+hA/C03hM2lfAq2 X-Received: by 2002:a17:906:f6c9:: with SMTP id jo9mr48021274ejb.233.1600670172005; Sun, 20 Sep 2020 23:36:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600670171; cv=none; d=google.com; s=arc-20160816; b=OTtloarp4ucN232ifJC1hpCN40oDVCl0r+T+fNWz1YTT9D1HsAB0i9ZUwQHZIyHpuo +nCZHbFTapxYPZDiBjAlaIwb0RkvDnYyHoR828qJ4Bbtrsb8igNs1/k+eo5zUL0L5KIr 82V3eJUUzBy6l0+FYfES5JkUg+oUuiR6PYGU6DHiI+ujE5uMizPjh/+kezROZYDJ+iod a3Q054o1qYD9KHYfcz5fU4vob6abfl6Z/Kl0eBMZzGFnNgksAIosEliFV/FNFj4LPVnl g1Z5h5PyAYr6EhMFlc5VmQJqHW0WnzrMK71A9I5EO6IYaCryY0ZqTheOzClvUpt6mbyL 1A+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ZHoLepD8M5uJxFyRdpMG3jxF4+924k9BXPCUz/4NH2Q=; b=VYizLq613dWP0XQx2J9pI17xNsxhrU2CqDg8Ibzt95J4yTA8LF/b++lO8QOjn8Pfbo /bEvRIXBWprVW0ATeGs+hEvjGXk1lvG2WZxPZ5OHSs1T5RiUV/4/gPboB+71VeA9vkXc Ymh005Y9NIREIb/PWWKP4LAmB+GDGTF6tvniSv/kRSQjKAKJkAsxlctBRYnV3dAjMMLl q8Nv2brg2XBcKsZc0LiUI0ZMZjfN+x8od2YOKL4S7phfk8DvtbTZf1q4DTiY6swf3yF4 1vSv2DPW0tE1yBlxAyJODX0a5HbOQzyrYlBPc8Wxo0P/Lsq7jHftxzncKnfqANlbFFMK 0dTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i3si8125195edj.574.2020.09.20.23.35.47; Sun, 20 Sep 2020 23:36:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726297AbgIUGeR (ORCPT + 99 others); Mon, 21 Sep 2020 02:34:17 -0400 Received: from verein.lst.de ([213.95.11.211]:38614 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbgIUGeR (ORCPT ); Mon, 21 Sep 2020 02:34:17 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4734568AFE; Mon, 21 Sep 2020 08:34:14 +0200 (CEST) Date: Mon, 21 Sep 2020 08:34:13 +0200 From: Christoph Hellwig To: Xianting Tian Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: replace meaningless judgement by checking whether req is null Message-ID: <20200921063413.GA18298@lst.de> References: <20200921021052.10462-1-tian.xianting@h3c.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921021052.10462-1-tian.xianting@h3c.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, this looks much more sensible than the previous versions.