Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2917569pxk; Sun, 20 Sep 2020 23:40:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVmNKTH5dYTWoVdOqHogpojZbgM4aDtz4liuLewVr6YxtrLHhWCHvGcXbKFr0klV3kGWV4 X-Received: by 2002:a50:da84:: with SMTP id q4mr49418821edj.238.1600670420491; Sun, 20 Sep 2020 23:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600670420; cv=none; d=google.com; s=arc-20160816; b=rd3nTy+lTanyijK1vBryV9EiM86VYCvU802Hptn4yCLn7iV/Mp0N4/a0htjwc8RDHX ifeCCknhpZkQJ8pxKcgkUjEbTHNGN559FtdnS5t1GyHSXI6fWAdpxii11Vc0xTSplqtF G6+ajpyOf/qC+jXqEhZTwR+ZZ43Q6j/2QqKnJcWZfLl8+t/yChrdge8lpuUxVYN6PRVZ voPtOysmcWbITc6nv3cTpK4vGxisD42lq0KnqYlK/kiQhyXvxNkFWv46pm3/H5PdxtcS kAADBIL5lk1Vg8x3/B+Rga91DrfCJceVIcshDa+xDtM0pMDMGe7Deqlf0RO3YLC3WHx2 fOYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=J0M2pyNhav4Mz9A/4Rlj3PSXxfv7KWICqY965Lz9dko=; b=pU+htB2mb+yAXpbb+A4bU1hBy/yUkwGfoU8oAWEl84HeBxceLPL6SI1ueSVBkxu17R vgSzpn6exQw2+1Yfn47CtHBEg8LozkPb7OHEqYt85ek5wx/l2f+T7aHXrTqwsPrmfsXo LoTkAP+lMpZ/MwmOrtIMF/i3yqwyrjibusJ5UD7nK/nL70qpR/9zHqNcWDici/Tsw9yC xjjEAv53iVsBhyVDrFhUt2jlpRtFx87ShkwRmlG8B/ffQdrcAfGAggciZixW58t4Yrrz Ouok19Tcjx+cfEJup6NE54BlS+6aB+ZT3nxLbCjgABRS2pEn/BNvk8m8GTH4sPYP7mkd n+fg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a23si7306142eds.607.2020.09.20.23.39.57; Sun, 20 Sep 2020 23:40:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726454AbgIUGho (ORCPT + 99 others); Mon, 21 Sep 2020 02:37:44 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:13738 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726011AbgIUGhn (ORCPT ); Mon, 21 Sep 2020 02:37:43 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 34CCCA880779C5AAB829; Mon, 21 Sep 2020 14:37:42 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Mon, 21 Sep 2020 14:37:36 +0800 From: Jing Xiangfeng To: , CC: , Subject: [PATCH] userns: Remove redundant assignment to variable ret Date: Mon, 21 Sep 2020 14:37:54 +0800 Message-ID: <20200921063754.179899-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After commit d2f007dbe7e4 ("userns: also map extents in the reverse map to kernel IDs"), the assignment to ret is redundant. So remove it. Signed-off-by: Jing Xiangfeng --- kernel/user_namespace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c index 87804e0371fe..0157ae92e447 100644 --- a/kernel/user_namespace.c +++ b/kernel/user_namespace.c @@ -968,7 +968,6 @@ static ssize_t map_write(struct file *file, const char __user *buf, if (!new_idmap_permitted(file, ns, cap_setid, &new_map)) goto out; - ret = -EPERM; /* Map the lower ids from the parent user namespace to the * kernel global id space. */ -- 2.17.1