Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2931917pxk; Mon, 21 Sep 2020 00:15:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlJ0G9O+pJlQC6OAIFCzIvwRU5tEOLVEr2Bf80rKokn1lNw31YZs+hLfFEDBFHhmw/w1md X-Received: by 2002:a05:6402:1d05:: with SMTP id dg5mr49681907edb.67.1600672528191; Mon, 21 Sep 2020 00:15:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600672528; cv=none; d=google.com; s=arc-20160816; b=nNh8FZwu5Trh3tuJHE4LXjrrLFXxE2pJEDH/ciJm61p30cYddYRGi8JVTWMymjgdVi TA/SaiziMHxJnV+c5QgMs5uIo5pMuTRvIZaxKWTZn88tn9VaXOnALYYv/hhkSRxGOIgO fRKBQs02zeL6gIHiheNvnMDSSGy6SojAVcOse6TlBb0RtyNqVFtFl4wHN3YrKqT9llr+ 2Sz62Xsm1Iei+vFK1baiekkqWzGzQvXFejp/1/aGR3rFe8qCTSFpAKG5P0ywQ/Es6aFJ mI0EslOcrwtV00RzVtZHu+PRZ9ccai3xuqTdskk0jU6yDmoUxffuZWcly0z6KwZo2MPP a39g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=j1hyi4uW0dW+lCsxRl1fZv8pS3WTC62bapK32xNJUIU=; b=vrQDbBwE9UazKzU6KlfqsuAJ1q6jgNctPaoj07pzJ5UGqwDE9aH5xlqBQrAqUUIGLD o4NiivItumiDU1cWo5YmrvufMsdSqvMQPFH+N+Unwlx4uxijuX4hPUdHFZrEWtBmWNKR rR40mtuM4gPLIT7JB4DMVyxtzUoJNRSUKVRDkbEBf32AVcN9JdVYGM04WtAphEZYSu9v JTXYLQjBjJcW4/Yv42aPwlDJP7kEHibszt91I49NPniui0G8UWoyL3lh4nNdNnxASxMQ 1mT/XdlRrkcT432+7qJ4RpwNvwR8J1IVmkAhM1jGscb6rQE1lWx6XanvgMbdq9DsMX6l 1pOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=jrGCZItd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds1si7377638ejc.279.2020.09.21.00.15.04; Mon, 21 Sep 2020 00:15:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=jrGCZItd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbgIUHOK (ORCPT + 99 others); Mon, 21 Sep 2020 03:14:10 -0400 Received: from smtp-fw-9102.amazon.com ([207.171.184.29]:25423 "EHLO smtp-fw-9102.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbgIUHOK (ORCPT ); Mon, 21 Sep 2020 03:14:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1600672450; x=1632208450; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=j1hyi4uW0dW+lCsxRl1fZv8pS3WTC62bapK32xNJUIU=; b=jrGCZItd0OmeiReGQ2oCAIMqhnTHLLdkxDKXIwC2xu2i8CawKluvlmdJ A2XhXqr1xxVRAl6eekPDt4NT48NqPrrIOHs2ZvRfj1qzdUREunURwmZJZ et3LozQyF3AOm4aOWJ+1qZ8i1soNoM2I6j4eZfR5KqeWrJ9uafC9RUepE Y=; X-IronPort-AV: E=Sophos;i="5.77,285,1596499200"; d="scan'208";a="77766272" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-715bee71.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 21 Sep 2020 07:13:57 +0000 Received: from EX13D19EUB003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1a-715bee71.us-east-1.amazon.com (Postfix) with ESMTPS id 60712A06C3; Mon, 21 Sep 2020 07:13:55 +0000 (UTC) Received: from 8c85908914bf.ant.amazon.com (10.43.161.237) by EX13D19EUB003.ant.amazon.com (10.43.166.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Sep 2020 07:13:49 +0000 Subject: Re: [PATCH 05/14] RDMA/efa: drop double zeroing To: Julia Lawall CC: , Yossi Leybovich , Doug Ledford , Jason Gunthorpe , , References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> <1600601186-7420-6-git-send-email-Julia.Lawall@inria.fr> From: Gal Pressman Message-ID: Date: Mon, 21 Sep 2020 10:13:43 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1600601186-7420-6-git-send-email-Julia.Lawall@inria.fr> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.43.161.237] X-ClientProxiedBy: EX13D08UWB003.ant.amazon.com (10.43.161.186) To EX13D19EUB003.ant.amazon.com (10.43.166.69) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/2020 14:26, Julia Lawall wrote: > sg_init_table zeroes its first argument, so the allocation of that argument > doesn't have to. > > the semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x,n,flags; > @@ > > x = > - kcalloc > + kmalloc_array > (n,sizeof(*x),flags) > ... > sg_init_table(x,n) > // > > Signed-off-by: Julia Lawall Thanks Julia, Acked-by: Gal Pressman