Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2970434pxk; Mon, 21 Sep 2020 01:41:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzy/s/V1OYsf1sdNXWV+rBP4030ijZQrAvBWo6ZemTQSu2tb+11aVp51viuHu9/bgpGNeVW X-Received: by 2002:a50:f28b:: with SMTP id f11mr50330339edm.44.1600677719168; Mon, 21 Sep 2020 01:41:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600677719; cv=none; d=google.com; s=arc-20160816; b=lLjR1r8ncdRE2J+hgT9ofsWvom3gA9MlTv02PooJOl1NaL1rADjm1VTY9oYzb2MoI4 HgOwwUXQwrMgx2sbb/5HZ6K4Q5cXIfoDbXPDb/ecWv/RnVr3ya3wpZMUbdX1oouPATMt GQI0QSyqjwpunlLMHc+oSo0te7y4VC/ZOP0LSEPk3ZAmjXNlm5qDsPGFjtQda/++sdGa IR4QsKHEItbkdUH0sjE523tWNujnY3RmkvyHcXB1Ktd9wSngNueu6CoSwr+FMEP8uOBi JWyz+t3nLH8siZIolb8SQFeFcg/3yeGWLMdpMx28Bbh0N0nooWPQvezUP+Q1KN97xxkF WyiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=LVd16FYLAMdC77Pdt6rdb96AvyWmEeiXLvGQqj9O3xg=; b=Dtbe/qKP0ukPIxfNNqTPnDYyY3SzKtTWJIh8UWN+5dAJZ8ck8QbU0uCEnCcQVnURaM nBSiGANXm/A7TEcwYUTFX3dhuwCD3wFmJT/87YeY6L85vlddr2eFsYeMEelo9z+V7rzb sixnKRHy4vpv5dMdn/8kgsHdhaMK/tPdIXUPMj8eyBJJ85OJg1ccvUPqFZCsQb68Q2Fj 9u92GkSuwIMCLvGN2vMlCgXKAQ8C/K2hsov/6E2VNgQxGHUq4WQgcWOgzHCta7gmMEL2 P9X6J1RnJUTC+2Z1cUNNjIYONE0PjvGLYPprMPe1rHzGxyg7ZOywiV8DJrFzqNHkw6Td 2Vwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wildgooses.com header.s=dkim header.b=oSP21rLm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wildgooses.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q5si7255870eji.118.2020.09.21.01.41.36; Mon, 21 Sep 2020 01:41:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@wildgooses.com header.s=dkim header.b=oSP21rLm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wildgooses.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbgIUIkd (ORCPT + 99 others); Mon, 21 Sep 2020 04:40:33 -0400 Received: from mail1.nippynetworks.com ([91.220.24.129]:43210 "EHLO mail1.nippynetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbgIUIkc (ORCPT ); Mon, 21 Sep 2020 04:40:32 -0400 Received: from macbookpro-ed.wildgooses.lan (unknown [212.69.38.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256)) (No client certificate requested) (Authenticated sender: ed@wildgooses.com) by mail1.nippynetworks.com (Postfix) with ESMTPSA id 4BvyZ30kVwzTh4s; Mon, 21 Sep 2020 09:40:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wildgooses.com; s=dkim; t=1600677628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LVd16FYLAMdC77Pdt6rdb96AvyWmEeiXLvGQqj9O3xg=; b=oSP21rLmM+DskM36Tkxc2MyX5WdkQ1Upwv2ISYIyM+5PgHbwmJchPF1fqVHqV+vZH8xk/t U5xtvLfG2GaeSJXIltvBDbpq0W+nC1toZQeKUgcx3hrq8PTAY6C0JWdxrxioEEQpICPd5Q pzU0Ezhp0bfAuESig/gpPcJ+o6I8ca4= Subject: Re: [PATCH] gpio: gpio-amd-fch: Fix typo on define of AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 To: Andy Shevchenko , Hans de Goede , Mark Gross Cc: Linux Kernel Mailing List , Florian Eckert , "Enrico Weigelt, metux IT consult" , Darren Hart , Andy Shevchenko , Platform Driver , "open list:GPIO SUBSYSTEM" References: <20200920203207.25696-1-lists@wildgooses.com> From: Ed W X-Tagtoolbar-Keys: D20200921094026454 Message-ID: Date: Mon, 21 Sep 2020 09:40:26 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2020 08:55, Andy Shevchenko wrote: > On Sun, Sep 20, 2020 at 11:33 PM Ed Wildgoose wrote: >> Schematics show that the GPIO number is 55 (not 59). Trivial typo. > Does it still DEVSLP0? Perhaps you need to drop that part as well. > > ... In the PCEngines schematic it's labelled as "G55/DEVSLP" (no 0) (In contrast G59 is labelled "G59/DEVSLP1") What is the quorum opinion on name? Thanks Ed W > >> #define APU2_GPIO_REG_LED3 AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 >> #define APU2_GPIO_REG_MODESW AMD_FCH_GPIO_REG_GPIO32_GE1 >> #define APU2_GPIO_REG_SIMSWAP AMD_FCH_GPIO_REG_GPIO33_GE2 >> -#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 >> +#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 >> #define APU2_GPIO_REG_MPCIE3 AMD_FCH_GPIO_REG_GPIO51 >> >> /* Order in which the GPIO lines are defined in the register list */ >> diff --git a/include/linux/platform_data/gpio/gpio-amd-fch.h b/include/linux/platform_data/gpio/gpio-amd-fch.h >> index 9e46678ed..255d51c9d 100644 >> --- a/include/linux/platform_data/gpio/gpio-amd-fch.h >> +++ b/include/linux/platform_data/gpio/gpio-amd-fch.h >> @@ -19,7 +19,7 @@ >> #define AMD_FCH_GPIO_REG_GPIO49 0x40 >> #define AMD_FCH_GPIO_REG_GPIO50 0x41 >> #define AMD_FCH_GPIO_REG_GPIO51 0x42 >> -#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 0x43 >> +#define AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 0x43 >> #define AMD_FCH_GPIO_REG_GPIO57 0x44 >> #define AMD_FCH_GPIO_REG_GPIO58 0x45 >> #define AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 0x46 >