Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 6cBIXqT17JyeQHhEhY4T+9xZmUfVBYUaj4nCfBnEBidaFxGKTKrjWD+jTnTTEEpm1n5691zZpW
 CsTppmG9TjgCe6PajBTgOxMwz6xNlvVtsd2mwdNzV++C7nE0MNNtzA1fy7ZoMP21YmgdRuC7lk
 fopUeQV5UceVWxFaHaLp6fK7yc5kSI3F90FRYcilRCqSQvEAOYyv6s2eydIStoJgdZMEe3JDJs
 yXHdOxzM5nZ3arar2YMJGjSYyKMh55fAmY6Ke2XCwao4cyLO1hDahEG4F3+dj8AMlaF3NHfrfD
 Kno=
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     "qiang.zhang@windriver.com" <qiang.zhang@windriver.com>,
        "clm@fb.com" <clm@fb.com>,
        "josef@toxicpanda.com" <josef@toxicpanda.com>,
        "dsterba@suse.com" <dsterba@suse.com>
CC:     "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] btrfs: Fix missing close devices
Thread-Topic: [PATCH] btrfs: Fix missing close devices
Thread-Index: AQHWj/EE9ACKFguCd0uLvl8x/+Qkug==
Date:   Mon, 21 Sep 2020 08:52:01 +0000
Message-ID: <SN4PR0401MB3598AD645D54CF397612EE429B3A0@SN4PR0401MB3598.namprd04.prod.outlook.com>
References: <20200921082637.26009-1-qiang.zhang@windriver.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 576d59a0-15a8-47f4-add9-08d85e0b9b2c
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 08:52:01.2363
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SV9z/cYMBdm3mgL4odYgtuXoUd2KReWZcOWyJQekM/tp4Z95JAlOm6zvSGcyqxwBa/Av47hblsQIcmK3lf2Pgtv4eQXiOIAya2ZF6PSKtto=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4239
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21/09/2020 10:27, qiang.zhang@windriver.com wrote:=0A=
> From: Zqiang <qiang.zhang@windriver.com>=0A=
> =0A=
> When the btrfs fill super error, we should first close devices and=0A=
> then call deactivate_locked_super func to free fs_info.=0A=
> =0A=
> Signed-off-by: Zqiang <qiang.zhang@windriver.com>=0A=
> ---=0A=
>  fs/btrfs/super.c | 1 +=0A=
>  1 file changed, 1 insertion(+)=0A=
> =0A=
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c=0A=
> index 8840a4fa81eb..3bfd54e8f388 100644=0A=
> --- a/fs/btrfs/super.c=0A=
> +++ b/fs/btrfs/super.c=0A=
> @@ -1675,6 +1675,7 @@ static struct dentry *btrfs_mount_root(struct file_=
system_type *fs_type,=0A=
>  		error =3D security_sb_set_mnt_opts(s, new_sec_opts, 0, NULL);=0A=
>  	security_free_mnt_opts(&new_sec_opts);=0A=
>  	if (error) {=0A=
> +		btrfs_close_devices(fs_devices);=0A=
>  		deactivate_locked_super(s);=0A=
>  		return ERR_PTR(error);=0A=
>  	}=0A=
> =0A=
=0A=
I think this is the fix for the syzkaller issue: =0A=
Reported-by: syzbot+582e66e5edf36a22c7b0@syzkaller.appspotmail.com=0A=