Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 2/3] ARM: dts: exynos: Add assigned clock parent to
 CMU in Exynos4412 Odroid
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>
From:   Marek Szyprowski <m.szyprowski@samsung.com>
Message-ID: <d53d0b67-2368-1434-ab00-fb37b1e824a6@samsung.com>
Date:   Mon, 21 Sep 2020 11:42:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
        Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200911145403.GC15290@kozik-lap>
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20200906142146.21266-1-krzk@kernel.org>
        <20200906142146.21266-2-krzk@kernel.org>
        <CGME20200911150351eucas1p1c678e3ae20e49209dbf19c000ea033f4@eucas1p1.samsung.com>
        <20200911145403.GC15290@kozik-lap>
Precedence: bulk

Hi Krzysztof,

On 11.09.2020 16:54, Krzysztof Kozlowski wrote:
> On Sun, Sep 06, 2020 at 04:21:45PM +0200, Krzysztof Kozlowski wrote:
>> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI
>> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit.
>>
>> However the dtschema expects "clocks" property if "assigned-clocks" are
>> used.  Add reference to input clock, the parent used in
>> "assigned-clock-parents" to silence the dtschema warnings:
>>
>>    arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
>>
> Applied.

This patch breaks operation of clocks on Odroid X2/U3:

# dmesg | grep clk
[    0.000000] exynos_clkout_init: failed to register clkout clock
[    0.000000] Exynos4x12 clocks: sclk_apll = 1000000000, sclk_mpll = 
800000000
                 sclk_epll = 45158401, sclk_vpll = 350000000, arm_clk = 
1000000000
[    2.569484] usb3503 0-0008: unable to request refclk (-517)
[    2.848718] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2 
(50000000 Hz)
[    3.373850] usb3503 0-0008: unable to request refclk (-517)
[    3.542777] usb3503 0-0008: unable to request refclk (-517)
[    3.544005] usb3503 0-0008: unable to request refclk (-517)
[    3.559223] usb3503 0-0008: unable to request refclk (-517)

Please revert or drop if possible.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland