Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3023253pxk; Mon, 21 Sep 2020 03:22:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymEnsNMt5/VeLHV9Me5x50Ccu6lSOLYxkEIjtqk4vCkRZJtt9tipwEhrU604admvrSAAmM X-Received: by 2002:a17:906:ecf1:: with SMTP id qt17mr50116768ejb.158.1600683723537; Mon, 21 Sep 2020 03:22:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600683723; cv=none; d=google.com; s=arc-20160816; b=0Tuo7GF9H2+W+ZyLEYP3FloqMIOj7z/CW/qqdBgGIvukVk0E3xU2xzRbCRe+2QK4kJ USfbL//xx5/+BzlY1f2o6q899fLTa19fP91zDD3ZpxM0d36baIM+TU89BcIbsUEVWweh bXIaMwaosA5DtO8RSlQQ1iXrSqUxyNADKDB7pnluRrdzau9vexY4j1eaVHFKvled6FBs B8HPqQuC0j0L+VNLxeigZpwL33dwk0rvd14b2dynzm6qPDxwkyt7qspcmK/ONCDGneqH eJd4NhIKudFuAQleR0KoMfnq3qq/GpVYARUwnUU3tnDwgWPqlcWrFQ2WB90gMTPkfsbf +eug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:date:message-id:mime-version :content-transfer-encoding:references:in-reply-to:subject:cc:to:from; bh=rj4+M6DD6otkwDGZkPtBHSzGMkXryvZLbVWueeLZG8A=; b=a0Wzptv0+7NUzM21bqdjeuLYiiwcpMm6+2fsHR4kMJYlhC639fhqnaAqvxACczvEcv n++j1dPVcjUmmYnFFHw1WkfM1zWamQDxXfUCDMvQ9M6Ey+NfqBrr7WxsRRsc02r9KLbJ /t39zRDbSZgFAaAGpDIALA92Zy9HUXQt89r0+E/yWWyskdjbHdSGaGO/WA+RMcWjx7TH 0Ptl98M0nQKgx/ej1S1Qp8BGc/or+FkyXoz2HqykK7sqzN0esjEt/o5+CNNwsGQTk6wd XNWS2luTXguMkhKUE72y36Fs8ZESDJt8hcZWsr4giTSEtluzPwO6FjaBnIIP3PsTwgkv XkmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=YIlbcdmf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si7853478edp.364.2020.09.21.03.21.39; Mon, 21 Sep 2020 03:22:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=YIlbcdmf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbgIUKT6 (ORCPT + 99 others); Mon, 21 Sep 2020 06:19:58 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:18229 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgIUKT5 (ORCPT ); Mon, 21 Sep 2020 06:19:57 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 21 Sep 2020 03:19:44 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep 2020 10:19:56 +0000 Received: from [192.168.22.23] (10.124.1.5) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 21 Sep 2020 10:19:54 +0000 From: Thierry Reding To: Dmitry Osipenko CC: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?utf-8?q?Micha=C5=82_Miros=C5=82aw?= , Andy Shevchenko , , , Subject: Re: [PATCH v7 21/34] i2c: tegra: Don't fall back to PIO mode if DMA configuration fails In-Reply-To: <20200908224006.25636-22-digetx@gmail.com> References: <20200908224006.25636-22-digetx@gmail.com> X-NVConfidentiality: public Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-ID: Date: Mon, 21 Sep 2020 10:19:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600683584; bh=rj4+M6DD6otkwDGZkPtBHSzGMkXryvZLbVWueeLZG8A=; h=From:To:CC:Subject:In-Reply-To:References:X-NVConfidentiality: Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID: Date; b=YIlbcdmfvAOSf6IRQiDvnctM4mFiaFDgvqCZLM+Ie38OJYsafI0u1Zjt3lTXCcfKM XwWqIjV6F8LhEEcJoBE6CdisPfp+k7SUe/6MvaMxyB85+qlyUK9u8JePSQNb5Qwynk NEpLjRy/g2l6rQL9+XkTazAz9EYh2ApW6OFYirmM7ykmq7cZIbtfLqReGJQeQCnkQi rI+mPO7hJRn3iiMP+yYcFPrLCvZhI4H6EN3XmhqpXLx2ILu1gMkYYA/utOZSh3/+wb 0rZfJfq5h61NFPkqOeuJ4Npo9okSiacxoO6+MJ4JAoAN/nxTWjpxAHdhWkE0sLHjLy 6g4jKs6bc36QA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Sep 2020 01:39:53 +0300, Dmitry Osipenko wrote: > The DMA code path has been tested well enough and the DMA configuration > performed by tegra_i2c_config_fifo_trig() shouldn't ever fail in practice. > Hence let's remove the obscure transfer-mode switching in order to have a > cleaner and simpler code. Now I2C transfer will be failed if DMA > configuration fails. > > Signed-off-by: Dmitry Osipenko > --- > drivers/i2c/busses/i2c-tegra.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) Tested-by: Thierry Reding