Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3024096pxk; Mon, 21 Sep 2020 03:23:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyv+3rGJBRGbX5Ell5ml5T2oncGzkdnjB49gend5dtkCNyDk2P1GSu7+kIff0v6o6bdsou2 X-Received: by 2002:a17:906:11d2:: with SMTP id o18mr47855633eja.420.1600683800047; Mon, 21 Sep 2020 03:23:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600683800; cv=none; d=google.com; s=arc-20160816; b=U2gK2RcImmIIyWaGNq48/nOozJrHgeUV7PDJbMOUrwiDPuMIuPox0WaCQX8x4iAVeF UJn+m0x0kX290V7feRcQqVZ+G54uWdaB9JGvJPIn5YxZiXAGzOlXBvbSTzzlEzCCol/r pBmRR6qKaTNnL3ArZQ/xB568XN5Vgilh16l9cCohXj9d484+j6spPhLTHB+e7lLl/qAC 0FtEja9cLaxc66DqmgR8METz7fA6Sh26zqQ68PWeeejFDrZr1Y3bNmFuAKEy/DexYKJv X/RNE+SIo0q3pAnuWtgkoofcgMu5NUO81ywO7FNMEY8I+GNHxI2xmMwOZnhUXknhWog5 CmDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:date:message-id:mime-version :content-transfer-encoding:references:in-reply-to:subject:cc:to:from; bh=m4ZtxThMDRUEldsklh9qQCucht6X8R5Fx1EEDuEgQ3k=; b=TcwVtwIymY7838vE5L1ufriAlQsD/XY9ZkgfYbLimPyfY40GQzgtGI3EVRFckc1/78 WiWmn4QICdd1f24WFHDbsMFGaxwvirIbN/FHEebD2MTByiD7XNBCixbWB9ELduCA0/Pb avl3hTksZkkIPodpRe3DB2o+lxmXRQ8OtI9NzXlKxhwGyZkQtk7TzzrNXxpNQp9Fy0sj 8au3Ly8a3YJnQnVOx3HN3sP/q3gChhA0jnQgMmAfAElLvW682CV2UiZUN1UFcJMH+y7R rTbU+ljnHSZO+J6KAD7NX642uBdRP+fOA7icvUhsy157FTVirBHWmO/BWFcPE0jLoO2Y sjGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=bXiXu9NB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sa7si9069820ejb.714.2020.09.21.03.22.56; Mon, 21 Sep 2020 03:23:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=bXiXu9NB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726619AbgIUKT3 (ORCPT + 99 others); Mon, 21 Sep 2020 06:19:29 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:18186 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgIUKT2 (ORCPT ); Mon, 21 Sep 2020 06:19:28 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 21 Sep 2020 03:19:15 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep 2020 10:19:27 +0000 Received: from [192.168.22.23] (10.124.1.5) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 21 Sep 2020 10:19:24 +0000 From: Thierry Reding To: Dmitry Osipenko CC: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?utf-8?q?Micha=C5=82_Miros=C5=82aw?= , Andy Shevchenko , , , Subject: Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function In-Reply-To: <20200908224006.25636-15-digetx@gmail.com> References: <20200908224006.25636-15-digetx@gmail.com> X-NVConfidentiality: public Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-ID: Date: Mon, 21 Sep 2020 10:19:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600683555; bh=m4ZtxThMDRUEldsklh9qQCucht6X8R5Fx1EEDuEgQ3k=; h=From:To:CC:Subject:In-Reply-To:References:X-NVConfidentiality: Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID: Date; b=bXiXu9NB+GTm1r4pcRmY9g3+RwwQHi2O4dyBESUlYMA7ETlNMxt4/4tqdaNAJzMVh AVK0w3vousGaS2r9sq65MFE+jjC/VJTrqvHxbbxwqSN1j12lmaBP3qfMM3Y97M8VtA CQkQ8J0SQ7YWDjy3p+y91vzPV0G74VLQlO5mhIVVtVJ95zkhUOA3GvNzn/ACoQGhuH PTNyEVmTK6w7KMHn6t8Yuq+8SQVgY+5jMoF2RA/Z3w9A2ppVlaIQ6mzQdpmX1crZv4 csNCJbwTavrMVDqJbqT9f5k5DYAeXoPAD/VaqLXh8qQ7UR9rNTsyFqp4RBK2c3daVD 10yEPsWhDcT6Q== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Sep 2020 01:39:46 +0300, Dmitry Osipenko wrote: > The driver's probe function code is a bit difficult to read. This patch > reorders code of the probe function, forming groups of code that are easy > to work with. The probe tear-down order now matches the driver-removal > order. > > Signed-off-by: Dmitry Osipenko > --- > drivers/i2c/busses/i2c-tegra.c | 100 ++++++++++++++++----------------- > 1 file changed, 49 insertions(+), 51 deletions(-) Tested-by: Thierry Reding