Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3024278pxk; Mon, 21 Sep 2020 03:23:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6vCzZciMo8VKFRBeVtUvGd7mBQ+SH4L4JxFY9/V4+Rzy4srd33JYGu7clMTDONCQQcuvW X-Received: by 2002:a17:906:b156:: with SMTP id bt22mr48403390ejb.481.1600683820064; Mon, 21 Sep 2020 03:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600683820; cv=none; d=google.com; s=arc-20160816; b=XOTvSkRlxCK+q2zD7Qu8+7Ivk8d5+x3Grd+sjVTvCoGNUyzx3vjPzTEn31YV/MV7X6 PqzMjKegVmBkNYZxmHJgrZA/CqqgDg3AFyo/cZ13kSg9kxgxL50FLzf7YjJQsn85mRTI tJkzQsnOHCdQopLurerlPL6F9ovSBg9MhZ8+uuzXIi6bt5CI6CFKQQSF9+pXQrkrqvsb 8h4gVcGS7wHB1P3g/9HmNyPxK48FFT0z811Rxj2lkUDPz6tfOaJOQs3Q8IAHZupVjaLe pYh9K1R6Xk19oz89yxRKNibU9Sz04jO7hacBysPuZ3axvVR9nbrOkWWZNNnpm9yUvP01 ltgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:date:message-id:mime-version :content-transfer-encoding:references:in-reply-to:subject:cc:to:from; bh=lmbI4GAmfwbliMzyWCpPL2R4fY4K5nxPT6aSjRsZxd0=; b=Q4ELD8S206e0elMIjGH1tS4Y8xYBbOVaF90Ehd8bl/NvuFpmWAmBHG4ihpsvo82DQf TbSvR8bjpYrvUAzM0w+FcujC5qbrrlKIld/JvN3WHlB+Ki7rTjmTz675rbXIwZSZ6iyW G9nYc3/sY8GhJr7en8zwR8+j1Tl+9D6eul+apj1HfddmGW5BRAkYKB0RcyepQ/VjiWII yjV1NlLmP1yj0/+7HuzguZqgQoTYW9er8k8fHKmoGXgsYiYdGaZmee53x0Zxwg3EtJva KtlFWZx8ZkIgEeryhh53gc5vKtCVBpT+pzrs55tRjS61/Ks/YGPiCw488o6XEW+upZGB pePA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="WS7Wr/ea"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si7687895ejr.667.2020.09.21.03.23.16; Mon, 21 Sep 2020 03:23:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="WS7Wr/ea"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbgIUKTm (ORCPT + 99 others); Mon, 21 Sep 2020 06:19:42 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:18209 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgIUKTk (ORCPT ); Mon, 21 Sep 2020 06:19:40 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 21 Sep 2020 03:19:27 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep 2020 10:19:39 +0000 Received: from [192.168.22.23] (10.124.1.5) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 21 Sep 2020 10:19:37 +0000 From: Thierry Reding To: Dmitry Osipenko CC: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?utf-8?q?Micha=C5=82_Miros=C5=82aw?= , Andy Shevchenko , , , Subject: Re: [PATCH v7 17/34] i2c: tegra: Remove outdated barrier() In-Reply-To: <20200908224006.25636-18-digetx@gmail.com> References: <20200908224006.25636-18-digetx@gmail.com> X-NVConfidentiality: public Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Message-ID: <9d02d4c6e1c44493af80e992ef911eb6@HQMAIL111.nvidia.com> Date: Mon, 21 Sep 2020 10:19:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600683567; bh=lmbI4GAmfwbliMzyWCpPL2R4fY4K5nxPT6aSjRsZxd0=; h=From:To:CC:Subject:In-Reply-To:References:X-NVConfidentiality: Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID: Date; b=WS7Wr/eazE/Mq9dKr/I7kYwowRwndM4bQOADj8GxEGJV0F+IcK07dJgqbF1pwQN94 cPvdz/CN+ySGCS7LFzXnYzXRUOaTfEnNe+yr/tsnSGb9zxXzSKRv5tttgUgw59x0tm MhQtjy3M/vDO22OIQ2qvGtpEmUCPkCzhN6PXX4V2Mo+tlVyv8fJnkammW/bwAoYRNQ 0dqfRw2xk/EnlCi0MDG76fXxKhWnYjjPbSjtj0Tv6qtglupQOeus6vXPBLnLOfUpYP 2ueCc72J1iuwUkwEG86nXs3U9YPSfuNHj5j1IIyf/6xH2JX/niKqMno9cqaNnZaJLT GStCNexGVFPhQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Sep 2020 01:39:49 +0300, Dmitry Osipenko wrote: > The barrier() was intended to reduce possibility of racing with the > interrupt handler, but driver's code evolved significantly and today's > driver enables interrupt only when it waits for completion notification. > Hence barrier() has no good use anymore, let's remove it. >=20 > Reviewed-by: Micha=C5=82 Miros=C5=82aw > Signed-off-by: Dmitry Osipenko > Acked-by: Thierry Reding > --- > drivers/i2c/busses/i2c-tegra.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) Tested-by: Thierry Reding