Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3026028pxk; Mon, 21 Sep 2020 03:26:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm2eeVSyW39uYW9ciFBbmmu/Hn0iuhZsu9cQ4tYa03CcHkEX/WZxSG2v66bFdMNT8m9HQ7 X-Received: by 2002:a05:6402:21c5:: with SMTP id bi5mr6550427edb.380.1600683994223; Mon, 21 Sep 2020 03:26:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600683994; cv=none; d=google.com; s=arc-20160816; b=wySUX/P9xTMyuP7tWYhaWR2nOhN2lJdF6yHQJUUK5Imvz5x2M2w2zAGfIamiiJTmwF OSwYATlW5I/tkUemVgIcozk1JsKc160Us094rwQ7nu9uhtgjZfWZsyWhDPlUOJbknq5R aLChb9iNq3tJjcibMNxU4v2+eMb4HL0holXskTOlbUJ6/28jRtKVhbcaGtlm3JVt5jBG ieIuVk+mJ+O2N7ZSPKSYlOpQY3/tMl+jb2lAKT/CIs8yRC9cWHWN4On8MuoJvDlsKbZz eCJdpCDpnwS2KffS4M1E9CUictLqpChVNCGaLEhsO7WMu/ojVr0B4AHg0Co7YbM8/eTn EDRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:date:message-id:mime-version :content-transfer-encoding:references:in-reply-to:subject:cc:to:from; bh=i70FCSUV9flyEkpXv9CHGczlPR4717jAf2IAWaY1S94=; b=mkKQL76BVbhiY64VoJen2GyFJUciDIL2bdEupWrc3Kk6mZ4W53/QEX/L9RmbGLAaUS NSKl1MA5Dij0voM41ygh4KPuM7KPHmIg8983dAK0zketKs4lAs8OwAnUBeXmy6g8XkyS YQ7bvmIfLr8o2qGQq8ITHHO93Z5lMwB+P5EPcIuKuCayoThBrrthlvoGF+r1AFrlVkgM o6/wcJfZ28yut8tPH3378NMxQJptUj929MqALxNvTPcBtbQuzJUKhYpRFi63mdiWq0Mk noMh0ATFalRwQyhEu5C0lL3xZMSGGP0CS1DUzHudAuUAF52OwQIWay5zSb7Tu5Y+GCWC lGIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=jle6ucdk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt15si7961759ejb.22.2020.09.21.03.26.11; Mon, 21 Sep 2020 03:26:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=jle6ucdk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726688AbgIUKYN (ORCPT + 99 others); Mon, 21 Sep 2020 06:24:13 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:9083 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727265AbgIUKYH (ORCPT ); Mon, 21 Sep 2020 06:24:07 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 21 Sep 2020 03:18:20 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep 2020 10:19:05 +0000 Received: from [192.168.22.23] (10.124.1.5) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 21 Sep 2020 10:19:03 +0000 From: Thierry Reding To: Dmitry Osipenko CC: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?utf-8?q?Micha=C5=82_Miros=C5=82aw?= , Andy Shevchenko , , , Subject: Re: [PATCH v7 09/34] i2c: tegra: Use reset_control_reset() In-Reply-To: <20200908224006.25636-10-digetx@gmail.com> References: <20200908224006.25636-10-digetx@gmail.com> X-NVConfidentiality: public Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Message-ID: Date: Mon, 21 Sep 2020 10:19:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600683500; bh=i70FCSUV9flyEkpXv9CHGczlPR4717jAf2IAWaY1S94=; h=From:To:CC:Subject:In-Reply-To:References:X-NVConfidentiality: Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID: Date; b=jle6ucdkcjOgIIDkZMOYDIL2DC+x+Jw4z555oxmiWyLiw4/o0SsV62yXCSCbleLf0 tRxT6i70POpp6RucfbJ9Wvxm/FhzHC9RqQNZRWF3uI+0MPa74WqnmAcUkAFI4xRzmj OtCrfCXwWl9q8UVr13/A5BgA8MoOLx0lxEoqVTxHMtNaBxMNkFp6vk+qPGUYsViQT7 tIFX07mUAMqkGtvK7nGhPI1twszA/mkazvx0EC/QLauOWl66CvZVESSKo/7YJYFNrn 47RjIK4sYQvK1+kmae0xe/cE/N/St8l2MERyZrEEwbMbKqJIR8ShvV9fI5EmM/079w dgnXmII5zGhCA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Sep 2020 01:39:41 +0300, Dmitry Osipenko wrote: > Use a single reset_control_reset() instead of assert/deasset couple in > order to make code cleaner a tad. Note that the reset_control_reset() > uses 1 microsecond delay instead of 2 that was used previously, but this > shouldn't matter because one microsecond is a default reset time for most > of Tegra peripherals and TRM doesn't mention anything special in regards > to I2C controller's reset propagation time. >=20 > In addition don't ignore potential error of the reset control by emitting > a noisy warning if it fails, which will indicate an existence of a severe > problem, while still allow machine to boot up. >=20 > Reviewed-by: Micha=C5=82 Miros=C5=82aw > Signed-off-by: Dmitry Osipenko > Acked-by: Thierry Reding > --- > drivers/i2c/busses/i2c-tegra.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) Tested-by: Thierry Reding