Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3026113pxk; Mon, 21 Sep 2020 03:26:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk1BCSf9g1aeyxrmPq/DtldqMvfQNvATAltALTTnAO2WyApoccaMQO1xlejiFJNCh25py+ X-Received: by 2002:a50:a6c2:: with SMTP id f2mr6400031edc.227.1600684004848; Mon, 21 Sep 2020 03:26:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600684004; cv=none; d=google.com; s=arc-20160816; b=Nx+NjiM7RcN1zojP7xnGIaZfxorlKeR73SHfbiOE/pkMtdn5rmb3RBjkQyOsqY8STW iO7Wc70ig/CrJMoHqiFtYyVU5QRnH40sR5SyStMMbYKwzonTPDgmj3FUvuCY+9F486h4 9rwsKVcbUwchHx+pLyBL1hARmne9XHwZ6WVNDWiEZlcPVph1vcsERfVpP+plfSQrLTUU GlqISn8tWHaOyhYNNIbFCqywotJ5SjsN3q0vVL/jeoPf/mcM3LSfh4Ie+nOMcg4du3Nz /nPY02WPcdOI7eVAOyM3UhW8CRzEHMuOZorbsfO223pOBOQkK8FoMMh8l1iPruVm8/6o WdqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=9ZBjuGtlIQ8oulJMUmpkUNjlWYvzKi6Grt0GpSmmusw=; b=I7OzW+Z5Zq/w+O38RM6co7F6IF16WQNisi4il6p8kEm8CxwoJ0dJ+pAvrrbWljGeuH CupG8mwORQywNK/mIjwOGiUBgWIDVui2vdJUoTOnyYHNatbooFzsIwdQ7pCrWhq7CCF6 W0DCgt+igbrnzfRjeMnmx8Sxtf3ugWBQwszmcP4BdD9veA0LHAEG+8kOHvvGjv7LY8lW i5eNXBXqhYXPQTQaCY/9H66BSejqYzaY1u3eAMtA9VJyRHlqYBkbBwlzmNQxSt9mktwY GXq4uf2VVVjPZ+Mv2RvoSQGsGXkY/PWNUu1/490UVX4T+LXAxfI+62NsNwdVDu6HMijF o9+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=rxZwjV6H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c5si7815917edv.513.2020.09.21.03.26.21; Mon, 21 Sep 2020 03:26:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=rxZwjV6H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbgIUKVD (ORCPT + 99 others); Mon, 21 Sep 2020 06:21:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgIUKVA (ORCPT ); Mon, 21 Sep 2020 06:21:00 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D861C0613CF for ; Mon, 21 Sep 2020 03:21:00 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id x14so12096983wrl.12 for ; Mon, 21 Sep 2020 03:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9ZBjuGtlIQ8oulJMUmpkUNjlWYvzKi6Grt0GpSmmusw=; b=rxZwjV6HY9LG0dpHkUso3xgcTJu7kAviAeubkz4/JVYFg/pNiT7Mv0ja6GhsRuMgYB j5RydFDHDpcj6AtcVzbq+tBHf9E7bBVCehrc22Be6rCJ31ARmygdsxWk0KKPLR0isLzF GZtcCPBa0cphp7RHnHGfOaYKgli39BOriDPuBFnO2HQO36mlrtoowEm7ZGzf7Y+pZyV1 c5x80CK8sJiPuomKofPU/1tkVzdpjtpuCmWUpkFJ53ZMwsWwuevTyvmwGe3ezPDykPjg PKVRYplwuhfbBoF6bsfRI+4BbOEA/7K7BRVlQa8NOLvjAY42SPCmJa6qmBHkkI9BW5rR lONQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9ZBjuGtlIQ8oulJMUmpkUNjlWYvzKi6Grt0GpSmmusw=; b=jW1O14oQi5erxtpWZwZWAJHeoysklR56LOfdFeD3zkmAuGnybltVeeFwtkt6MUH+Z1 xhDF+kvjt4lqY4EGJM0ThzVbj15vkERkTXmrJ0SV0gSPt7nzphMVNapdktA9KQKPXgqe NOZ3FEleBLWyJIl2qMkbsQlejRauKGNLoYfQvKubmMel2OrWtpjNU+NxedxJwQDNXjEx JeOVctMQ75mfnUNS3JNr7mbDSX4A0FfAUwUkY54S6TcSDt+E157yqdiubUc/dqzxD66o Kp+KOxUjtUctBIRhxG4PdhNBgH/aad/6Ue2Jrzr26/lXEvakL/Gb6wFG6c652YsRFIlX zvKw== X-Gm-Message-State: AOAM533AyMq0M7fOu8s6Pz8DUZi+RpB3cLgqhnrGoOHH4L12umseIUic d4yjd3wzE9WdT9TxB9ZYlymVuWHUnXnnng== X-Received: by 2002:adf:9405:: with SMTP id 5mr28243151wrq.51.1600683659111; Mon, 21 Sep 2020 03:20:59 -0700 (PDT) Received: from localhost.localdomain ([51.15.160.169]) by smtp.googlemail.com with ESMTPSA id l17sm18804629wme.11.2020.09.21.03.20.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2020 03:20:58 -0700 (PDT) From: Corentin Labbe To: gregkh@linuxfoundation.org, laurent.pinchart@skynet.be, mchehab@kernel.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Corentin Labbe Subject: [PATCH RFT/RFC 28/49] staging: media: zoran: convert zoran alloc to devm Date: Mon, 21 Sep 2020 10:20:03 +0000 Message-Id: <1600683624-5863-29-git-send-email-clabbe@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1600683624-5863-1-git-send-email-clabbe@baylibre.com> References: <1600683624-5863-1-git-send-email-clabbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allocate the zoran structure with devm_ functions permit to simplify code. Signed-off-by: Corentin Labbe --- drivers/staging/media/zoran/zoran_card.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c index fe4d34e388b4..62e63804ae14 100644 --- a/drivers/staging/media/zoran/zoran_card.c +++ b/drivers/staging/media/zoran/zoran_card.c @@ -1017,7 +1017,6 @@ static void zoran_remove(struct pci_dev *pdev) exit_free: v4l2_ctrl_handler_free(&zr->hdl); v4l2_device_unregister(&zr->v4l2_dev); - kfree(zr); } void zoran_vdev_release(struct video_device *vdev) @@ -1101,7 +1100,7 @@ static int zoran_probe(struct pci_dev *pdev, const struct pci_device_id *ent) return -ENOENT; } - zr = kzalloc(sizeof(*zr), GFP_KERNEL); + zr = devm_kzalloc(&pdev->dev, sizeof(*zr), GFP_KERNEL); if (!zr) return -ENOMEM; @@ -1287,7 +1286,6 @@ static int zoran_probe(struct pci_dev *pdev, const struct pci_device_id *ent) v4l2_ctrl_handler_free(&zr->hdl); v4l2_device_unregister(&zr->v4l2_dev); zr_free_mem: - kfree(zr); return -ENODEV; } -- 2.26.2