Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3026597pxk;
        Mon, 21 Sep 2020 03:27:31 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwKg91jsdgquds0NxyuxxvelXDGuk9BDRwXRxCyep75Gtl4qJXbdx4BIn4U9UVpu5x3hJCC
X-Received: by 2002:a17:906:2618:: with SMTP id h24mr47302408ejc.198.1600684051768;
        Mon, 21 Sep 2020 03:27:31 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600684051; cv=none;
        d=google.com; s=arc-20160816;
        b=T5DgiuRqZiFmJjwnYVGGWupiqSTmXQ4ChGu9Cze4mK6auQYBfCgBqaBMDo03HZIJzO
         2PvY0McKEMZsUaamrLQpCX5oxpIOTrGW0n9TaUka/FmHwsYUag4aa7BJgV5tUzs7/XJH
         EVmwsTCJk6eCLHQ2DY+ER8ls7iMtnTPM7gogJVbOLRfFYtwGdofx/n9ZZJUia9hLj4xc
         jTtpE2OPMVFycsk3AaQSQldh7LsC7RvUvCNpIYTFH+zo6lcO5Xt/TnHsGvszunZgqvY6
         gN+WXsUx+CQgxqcAKq62dgkGiw2Faxk3f0otWmVq2EzkbX+HzD2kSrp7Zv0ArRX/4z2j
         tn8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:date:message-id:mime-version
         :content-transfer-encoding:references:in-reply-to:subject:cc:to:from;
        bh=VwxWUvvCDE3896KMNP0fBhjI2samcfhvauxAGLDWspc=;
        b=lq0sw6UgZZPVbNA9+b5f+EGz75r0ojrNjZywGTLlFwuo+Jl7d+4q65jKWdKqmTn3Ej
         2aecmGfZOavvxgu3UFe1pD6Bz93lR93kM2EiYKy9DtYwOZxZxuPgG/WzI4/Yv2sKsdkn
         V9MWknRTUCsKs7PNGQnEg6KFQtSNG/KjGnJ7U2mzsqa7lwF7UwPpRobInPvU7TVJYXfB
         wWWRWXTqW3BsLRQwZoNLg80kZdKnrA2L8Bfxu8Q7pDC63gMxhu3nEZmj17Ly2J11hd4n
         rNY7ebx4Vco0+ypZCP7KcROJq6CQ7fCverVz/IVUEssCExNY8TOmIoNlv7IJj7a1mM2E
         mjhQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=NyV4Fl3z;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id sa19si8394633ejb.506.2020.09.21.03.27.08;
        Mon, 21 Sep 2020 03:27:31 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=NyV4Fl3z;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726478AbgIUKXv (ORCPT <rfc822;yxhlfx@gmail.com> + 99 others);
        Mon, 21 Sep 2020 06:23:51 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:9066 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726832AbgIUKXo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Sep 2020 06:23:44 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f687dd40001>; Mon, 21 Sep 2020 03:17:56 -0700
Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep
 2020 10:18:42 +0000
Received: from [192.168.22.23] (10.124.1.5) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend
 Transport; Mon, 21 Sep 2020 10:18:39 +0000
From:   Thierry Reding <treding@nvidia.com>
To:     Dmitry Osipenko <digetx@gmail.com>
CC:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Wolfram Sang <wsa@the-dreams.de>,
        =?utf-8?q?Micha=C5=82_Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        <linux-i2c@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 03/34] i2c: tegra: Handle potential error of
 tegra_i2c_flush_fifos()
In-Reply-To: <20200908224006.25636-4-digetx@gmail.com>
References: <20200908224006.25636-4-digetx@gmail.com>
X-NVConfidentiality: public
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Message-ID: <6f29761e17f1461ab21d6e9bcd6d3713@HQMAIL111.nvidia.com>
Date:   Mon, 21 Sep 2020 10:18:39 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1600683476; bh=VwxWUvvCDE3896KMNP0fBhjI2samcfhvauxAGLDWspc=;
        h=From:To:CC:Subject:In-Reply-To:References:X-NVConfidentiality:
         Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:
         Date;
        b=NyV4Fl3zuc3mcxm1IFkyYiPOuU5Uu46R4QXrYk7JsqbaaXs0hnTLKW6xivismTjpI
         FStG80Nn41/Lk+TEtvbvD2K+pz7iZeFgxaa6zE92cfsWw3T9hErOsy+MsWOe6Fbx6D
         AbPKMwep/Uleot1EUJQDP4cV321EsPTzvPfoL/opx/hAjkM0hwCH6K7SPz3hWf8W+P
         G6Z+5TiHRhM2M7OiY2P3rOwD/1pDDCbZBjnvKwSZlhvrI9mtLPIZfc/c4WiiTZJHA4
         xbOHcEqUDGASm1OdqFuuCAwgYILcBYoG01uLSOFXmfdaao0I16BQ6YMWiRpAXlW8YO
         nLNmdVsmUhLOQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 09 Sep 2020 01:39:35 +0300, Dmitry Osipenko wrote:
> Technically the tegra_i2c_flush_fifos() may fail and transfer should be
> aborted in this case, but this shouldn't ever happen in practice unless
> there is a bug somewhere in the driver. Let's add the error check just
> for completeness.
>=20
> Reviewed-by: Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qmqm.pl>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/i2c/busses/i2c-tegra.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Tested-by: Thierry Reding <treding@nvidia.com>