Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3026693pxk; Mon, 21 Sep 2020 03:27:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTBnEp1n/XBTnJpAj6GY8G9nN8jBY37fE5dzjTkJKX8UaYIG+qP9vahNj6G99uapgcOQOW X-Received: by 2002:a17:906:8543:: with SMTP id h3mr47914814ejy.258.1600684063077; Mon, 21 Sep 2020 03:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600684063; cv=none; d=google.com; s=arc-20160816; b=wN73swq5X0rDK7p+E/Xh84Tx/zoQ+4Gh1kL5eADG7YT/lMsZFpIhWO2MFZ8H9Hpds7 VXDVNFqMfNtgQQ6MlIk5KTjaigpb58SF7QXhpFIevPvXntkE81medWx26hhQMDtAwsj6 eiZ4tWxH9QrOdjBZYP4cBatFs/v+i1llDSMNUZE7AL6BcNbfNXbDmEJct4gTKZQcqvyL I/4WyBBNvoee4zD4rMBpp4vhpYn6dMNHTu29QyzWp8xN/ddwtdElDIFsKE8E/sEkZxSG m7TajILJnWv4qV+MDvgxlDvjgzxl1YPDvSXgrWnLYuPP5/9MjY7lRuvtJcsFzmSs5XfH 5C/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:date:message-id:mime-version :content-transfer-encoding:references:in-reply-to:subject:cc:to:from; bh=i/TazrAKHvxh+5rLEbVuNQITG8MRoX5xzCTI5hmigPY=; b=DMvbcqWW/iHumYrD5FTmQt0N/vyD68Bt0sY6CQPZnudxlOY+TlxrwTQy0cn7FNjXca Y7RdTgw9itH8Z+/i+4YfNlwTtAl915CQqkUgG+RLGq+EX6iW6L59oGwUlSP2kQwvLeXK Zv4fR9imaILBXTa/HZHImG9R2RLMWFjm8cETQEJnhtlBHdctQltHzfWK1mgkdg9X0sfZ s2VH0bsRVJ+XW7WEYAyhxBkeJuH+6G1uGKGGqNq6+iEQcER1H96DvxX8omKqxqoRXmuK 8XpHy7n4axgb2FYUg60VswEhp9r+ja7tqgSZ+MIGk96+cUf2mbsQfJS0sfcM4V+ME8/C Jcxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=JNSBViVR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o12si7879731edq.190.2020.09.21.03.27.19; Mon, 21 Sep 2020 03:27:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=JNSBViVR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726658AbgIUKZZ (ORCPT + 99 others); Mon, 21 Sep 2020 06:25:25 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:9237 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgIUKZZ (ORCPT ); Mon, 21 Sep 2020 06:25:25 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 21 Sep 2020 03:19:39 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep 2020 10:20:25 +0000 Received: from [192.168.22.23] (10.124.1.5) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 21 Sep 2020 10:20:22 +0000 From: Thierry Reding To: Dmitry Osipenko CC: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?utf-8?q?Micha=C5=82_Miros=C5=82aw?= , Andy Shevchenko , , , Subject: Re: [PATCH v7 27/34] i2c: tegra: Check errors for both positive and negative values In-Reply-To: <20200908224006.25636-28-digetx@gmail.com> References: <20200908224006.25636-28-digetx@gmail.com> X-NVConfidentiality: public Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Message-ID: <71a199bf16044d93a952fc4f27f28426@HQMAIL111.nvidia.com> Date: Mon, 21 Sep 2020 10:20:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600683579; bh=i/TazrAKHvxh+5rLEbVuNQITG8MRoX5xzCTI5hmigPY=; h=From:To:CC:Subject:In-Reply-To:References:X-NVConfidentiality: Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID: Date; b=JNSBViVRORvPhtQH4ZS+uZn6uVl6d014Li4B7HkLGggmbkICWL+0gxzQP8ORBd+nt uHApiz3mO1uGzllgP1nF3Wb+gZiALe7Eb+G71nWUmGK97j0Q9weuYd08PCk7hin0hp KarPB+KtN+JbnDjDnyybxxMoYO4hSqjcYbnDRSyWF5X8GuLQLNUaQr8IHrCVROs2qU cAm6JYdT1zs2EgI4cSTYAFF8/QxcBTLW379YVDwh8g1Hp5e1kTShSuzD1kS4opFYtf w8+H5IsJ7igZmn/QKFrmDmupXbynshynu6DzIkcaOGsxCGUY0t4GOWXbBPgdvJV8b7 DwyqYyIQfnGYA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Sep 2020 01:39:59 +0300, Dmitry Osipenko wrote: > The driver's code is inconsistent in regards to the error values checking= . > The correct way should be to check both positive and negative values. > This patch cleans up the error-checks in the code. Note that the > pm_runtime_get_sync() could return positive value on success, hence only > relevant parts of the code are changed by this patch. >=20 > Reviewed-by: Micha=C5=82 Miros=C5=82aw > Signed-off-by: Dmitry Osipenko > --- > drivers/i2c/busses/i2c-tegra.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Tested-by: Thierry Reding