Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3026810pxk; Mon, 21 Sep 2020 03:27:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyV0LybAg3Nfc42Stywl+Apg/HHh8O8Gtpl7Wf7eDsWGH02aCombqKnDyvYRVDgH3wcPXDP X-Received: by 2002:a17:906:594c:: with SMTP id g12mr50621739ejr.347.1600684073394; Mon, 21 Sep 2020 03:27:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600684073; cv=none; d=google.com; s=arc-20160816; b=lu7n/KTB8OlS7dB3cl9GYWWrbioFJ7G/30Gj+QwyFTchZAg6FrS2dgNJY3gU0iB2c+ ob8VGBFqoCSptN8GYTBhg92gB2tKbbO1wPnBda/xQZ4qZDdSf82SeApTVUKmhlAAk9Kq psAZHT5uK/f97h75D93SaCcVOgi0t4oGeDg3uwg1zF18lHsOd+L8szTZiDf/MYlaDshh JqhYANyBfERpsNfOklsBUHHoTqH76qOou4RDFiBG58fZajZkgLRhulzFLJZQz+ROcI1W cDXvTFPsTuKF+3a9pBr6KVcrsxRyftGIdnUxc2dsTOvWytmpPmVAv7ajR+ustsvw3uGr PDpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:date:message-id:mime-version :content-transfer-encoding:references:in-reply-to:subject:cc:to:from; bh=JfxTTJy+J3gpSKXyQSD0D8YeOpOU2N29tKNLl3yaQcw=; b=rFEM7Lcr3YBL0JU/kBK6n2bkP9sIImHnqpjfWcK3ja0+fxe4IAZrlA8WNkVEL+mB4g dA6Xvm5BZe/G4wcl76KF0xf+ww+Kdu/Jxa2GNeQlpOodBfluSKPT2V7QJjRSC4B4vrU9 V0u6ImAwVQ8bCDAivUGncEoxKwQ1xZjjOE6o1oZmK3TaHtT9VWALxqeeYU95cBQZiLsw lflW9BMqoqV2NB0kEV5jd9zWs3eV0rQcLpS1iUG8F4Q40Fb9GUzziGfzSw77pY8lxUXf l9VhmlwK8GDHAUefpm169zIcfdS+fv2cqpL+JOaYddl8wJ80L/4mhvGW2Hr+nD1hh7LB 0glA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=RSZNVenT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lr3si8794824ejb.744.2020.09.21.03.27.30; Mon, 21 Sep 2020 03:27:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=RSZNVenT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726355AbgIUKZj (ORCPT + 99 others); Mon, 21 Sep 2020 06:25:39 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:9259 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbgIUKZi (ORCPT ); Mon, 21 Sep 2020 06:25:38 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 21 Sep 2020 03:19:52 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep 2020 10:20:37 +0000 Received: from [192.168.22.23] (10.124.1.5) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 21 Sep 2020 10:20:34 +0000 From: Thierry Reding To: Dmitry Osipenko CC: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?utf-8?q?Micha=C5=82_Miros=C5=82aw?= , Andy Shevchenko , , , Subject: Re: [PATCH v7 30/34] i2c: tegra: Clean up variable names In-Reply-To: <20200908224006.25636-31-digetx@gmail.com> References: <20200908224006.25636-31-digetx@gmail.com> X-NVConfidentiality: public Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-ID: Date: Mon, 21 Sep 2020 10:20:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600683592; bh=JfxTTJy+J3gpSKXyQSD0D8YeOpOU2N29tKNLl3yaQcw=; h=From:To:CC:Subject:In-Reply-To:References:X-NVConfidentiality: Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID: Date; b=RSZNVenTsrz9smqn4QKB3PxX4gMNyhvNyYvWUShoX/zybnmmchmjr6zOtMRqQWKBA slq7kFiNhhNgOqyZFry8tgaBb9nqqUTx6Zo/zrmEGEfnkBi5mxlxY+J91OVZSd00Cs kXaTqGS9KQ3/Dzvlnd3gSVcfhrDO97pBCzdT+gRScGA/qXoz41l7lu70OJL2qHq2bB ojL6/GCbtcig7c6n52qgs/wTh/hUz8W3w4XY+NqQN8P52XXgJt/e54FErejZ9697Bb D0pBOPZg5PZNf5FDOqWlhYlrhEv8UOe/Qky9YFwRXCPp7451AnlfsY2k5Z5Ej6BNBT 6H4TORa9Z6GXA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Sep 2020 01:40:02 +0300, Dmitry Osipenko wrote: > Rename "ret" variables to "err" in order to make code a bit more > expressive, emphasizing that the returned value is an error code. > Same vice versa, where appropriate. > > Rename variable "reg" to "val" in order to better reflect the actual > usage of the variable in the code and to make naming consistent with > the rest of the code. > > Use briefer names for a few members of the tegra_i2c_dev structure in > order to improve readability of the code. > > All dev/&pdev->dev are replaced with i2c_dev->dev in order to have uniform > code style across the driver. > > Signed-off-by: Dmitry Osipenko > --- > drivers/i2c/busses/i2c-tegra.c | 173 ++++++++++++++++----------------- > 1 file changed, 86 insertions(+), 87 deletions(-) Tested-by: Thierry Reding