Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3046132pxk; Mon, 21 Sep 2020 04:01:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPgkoW8h243l7ooD4lDq+TEJojj704EvIXkFBN4wIlh2IwLekDD9QYdU1s7W7z/a9OKTdE X-Received: by 2002:a17:906:8682:: with SMTP id g2mr48815810ejx.110.1600686108945; Mon, 21 Sep 2020 04:01:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600686108; cv=none; d=google.com; s=arc-20160816; b=XrwhegHVPKs0X1fVqB4W3OJSKAeeuH59Cre2MvfnXAW0njhN9hetVYYV8q6G5H1gcr p20lyocXSjVmk6XCYVRd8Z5l43MQHSPFhqBymsblCPhXsclPbQXgsQwyUCXzDHMsMB0b vJkaVwKVP9wS6HGicy9qD14SuB65YVVzAfx/UP7VZyTINeR9GeVP03fqsBMDhvPp+MaJ 9q0OqUUhI8Ry5eSqsh3unas4EQCjcZg6RSen3m+nQqZ/PeBL7meGbhzhezmA8KrtNkdX EVib0fsqOUdUY1cQzIWzulbigMWQVfs3j8Y7oJ+JEmqmXVA7d745HkUa2A0Fg2yniqzd POZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mizNCetwIsKZgA064lowgkb/h+Rqt5ZeNuJvt1Lw/Qc=; b=qv5ptZGthf325FC9lC+Gmev/BolA+zUISVVQGlI6KjCLGE+y7sFUlBB/JclZFkckdt SZtM8ihCRHBk1R4ngEAeQo3z3NYp3C9P+dyiZu5Gdt/Y79JmfX3Mh2W4uPHJj/3ospPb H8I1xQTnSbbpn6SuiSm+ExhOblcIdhrBRkw8HrcaW1J+82B8tRfyf10rICb8NjX0SdCX 68RpaYMQ6sUcUSCTjXBs+dn7xEfjoEYTq93PE2Oug1fYo+jeBra37pxF1jxQaXo+Fu8I lqHVl14K4PhvmKuJpremFDsxiJN53mo3fKsq+sPnsvnxGPzc2omSivhQ7he9KQ2o2vOI t2Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=De0GAbH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a42si10884412edf.535.2020.09.21.04.01.25; Mon, 21 Sep 2020 04:01:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=De0GAbH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgIULAV (ORCPT + 99 others); Mon, 21 Sep 2020 07:00:21 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:53312 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726347AbgIULAH (ORCPT ); Mon, 21 Sep 2020 07:00:07 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08LAx6PW096803; Mon, 21 Sep 2020 10:59:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=mizNCetwIsKZgA064lowgkb/h+Rqt5ZeNuJvt1Lw/Qc=; b=De0GAbH2NmtT4kjSmbOfXRmbcK0O9EsiFRi3I7mhfvRujwArTig5lMsYA9lZomhpvzV9 x5jjtyBhMC4O9iAUZfJ7Z6KyHw7TxwfTNjWgMjasC/LLM+B7oLzuANt3uFlILzG/R0Oc nPGnVTWjgIqWdBWzWNeS7Xwf3J1wXY95nJWulN6gbUBDNl62ueBZl+PdbrAg5xEfGEh8 Jsq2N3yqZ/AyCfIdFWkL9nWWTN2VWt9OK5d/Dq1viYsPedKIe8vUnANov4Me0VxsOIMn oij6sA/ZVtbDQ5RBUarGf1xVLr7C5/qJEt3jRTTwaEgqgBH4reN/DKj6GgAG7tP8Sy5M 2Q== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 33n9xkmx2f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Sep 2020 10:59:57 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08LAtK6W139782; Mon, 21 Sep 2020 10:59:56 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 33nuwvxuq9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Sep 2020 10:59:56 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08LAxruR032760; Mon, 21 Sep 2020 10:59:54 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 Sep 2020 03:59:53 -0700 Date: Mon, 21 Sep 2020 13:59:45 +0300 From: Dan Carpenter To: Corentin Labbe Cc: gregkh@linuxfoundation.org, laurent.pinchart@skynet.be, mchehab@kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH RFT/RFC 37/49] staging: media: zoran: add fallthrough keyword Message-ID: <20200921105945.GC4282@kadam> References: <1600683624-5863-1-git-send-email-clabbe@baylibre.com> <1600683624-5863-38-git-send-email-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600683624-5863-38-git-send-email-clabbe@baylibre.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009210081 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 clxscore=1011 mlxlogscore=999 bulkscore=0 mlxscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009210081 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 10:20:12AM +0000, Corentin Labbe wrote: > This patch adds fallthrough keyword where appropriate. > > Signed-off-by: Corentin Labbe > --- > drivers/staging/media/zoran/zoran_device.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c > index 9558bafdde7d..7634d94f9359 100644 > --- a/drivers/staging/media/zoran/zoran_device.c > +++ b/drivers/staging/media/zoran/zoran_device.c > @@ -268,7 +268,9 @@ static void zr36057_adjust_vfe(struct zoran *zr, enum zoran_codec_mode mode) > btwrite(reg, ZR36057_VFEHCR); > break; > case BUZ_MODE_MOTION_COMPRESS: > + fallthrough; > case BUZ_MODE_IDLE: > + fallthrough; > default: Hopefully, we don't need fallthrough labels for empty switch statements like this? regards, dan carpenter