Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3064459pxk; Mon, 21 Sep 2020 04:30:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxigWQ0rYi0ibewyWDVWV41CzGJxTZ/y7zsM5jawFQw6hQ1yVDN6X5bt5UUu8R9F+tITkVJ X-Received: by 2002:a17:906:480a:: with SMTP id w10mr48560342ejq.372.1600687805987; Mon, 21 Sep 2020 04:30:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600687805; cv=none; d=google.com; s=arc-20160816; b=wUXtCa3CxvugpH3ZYqVhP2CZ/1sW6y2nvTJRYp7OrnvZMVNZpiCuCZ9asY9IwOJ156 dpzxQ+Ai/8Hr4jltw7QMqN/2QmTFbM7nJpu1OYNJhq6ZSMnUXzcHbFXzh5MJvI8x34kw KfCPDpBSfM12JBKn0YCiwEkDjlnSlxIRz+gBNSCEHp2Ntb19GK5JYaSx66Wfn+P4PjZd +Hg3BDDqBcmig11M+qItimfdj2EswXI4UhWDIQ8y1ge9eR+oxfH1YeLIjDwqcmF7IEly Abs2Tu3dd420KMVhoCu/c0TwfQzbG7OjGOlmCeS4TFW0ND7/m3kOeGv3WJhIhANcaWH5 WkcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=vrB+wCY042lJLf7nGNWVAiX4/elJqpuJ2MLbBI8/1x0=; b=mrGW2DcMriUnjXptRKRx7783DNh/0dqZJSAyUdoK21xZXWChkZqTNgBlHiKmxdA8lN YntZluWnZfG6r/ig/Fo8cMJjzmcFqr5HPhd8qNEp5EnlC/jzxEwJJFp320aoBBTRKHvF bTFpHCBUD5a9gWvTchCWCIDgpyMCtguzJ/eE1vmWiwemtKhW1uKm7H6AS88GW4D5xO2m OSZeDISj2epGHB2PWG3lcZvqWsBGDEnWFDOCTmuX8izTp7C7WeWcr7Mt1OYh8OILSH2K /7zYfYcY17zDnlmcfUWH+ZREC3qOpZHOJyMKrZsM5+DIQevH6OyYfVHLOg0QQEFq75E3 7pCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lJ2PIn2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c17si8434761edx.209.2020.09.21.04.29.43; Mon, 21 Sep 2020 04:30:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lJ2PIn2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbgIUL2i (ORCPT + 99 others); Mon, 21 Sep 2020 07:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726648AbgIUL2h (ORCPT ); Mon, 21 Sep 2020 07:28:37 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9032C061755; Mon, 21 Sep 2020 04:28:36 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id t10so12351244wrv.1; Mon, 21 Sep 2020 04:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=vrB+wCY042lJLf7nGNWVAiX4/elJqpuJ2MLbBI8/1x0=; b=lJ2PIn2hyoicpc2UNBXM2gN4WBR9xUocX0CtaRAH1XEa1qqh0K3nyX8RXr586ComqS PXnrJXhtzG+wJmllnrGIUchNGpHYdFb/wX+qKb0BdbQC1EwTIjEUQiCEwt6PFomHiCux ncvCOwye3NFC+/iwCRVNBRzNy96hA4kSK8Hx8mxkFTHhM36udC+fFGFcuTtHk384dxzh X3T41btIzGWFA0tV8kaChIWjovCidbqL1YtOIIocGDPQIiXEFTSLltnzukxKavn5VUjj MHNAVIN4wrxH+ZpdyAV1maFMOLSSAuAqyVGdWLotwE2PRzlv+BpMN//f/gR2153lBivD oXcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=vrB+wCY042lJLf7nGNWVAiX4/elJqpuJ2MLbBI8/1x0=; b=rJDnF0V6fRNTRMTPS8REUhqGTPLLxc7G15/bZL56RxtFRjs3/GFwCEIOYlLUQnOPgf lUymz8YnHz/Oj1ttb47m1WLplVb1GQaMbSeyPMnaS1qWrZpzdkrIX2nhOdBsnr+WTzRn NaLzHy1D44sGl9xCA8qX2kdfcvSfFy5+TG18Bm4UrCT+yB7tJbxnzZZe3yh6qBfzlj9f bRX9FOYmaP4UL8gDAcoDIqNNrO1gqUsBTSHVOcQtZTpywlTAo0mAH5OYTLZg3wwWyO6w m5weLCZkI3OWe4pb0APok9txXek34lT6VUdVr2CildmkSJU8tqM3W3RjvKUgOHd5Dpd8 gzUQ== X-Gm-Message-State: AOAM531+HL7FCQ6uZzVT0iMYHTLqkMyr346HB0sGrdDpsau5IzANTUq3 nbuiHX7ME/nQ7Ip/nmhnBa2FdD+pWMVyhrAG X-Received: by 2002:a5d:61c7:: with SMTP id q7mr52716640wrv.343.1600687715532; Mon, 21 Sep 2020 04:28:35 -0700 (PDT) Received: from ubuntu-laptop.micron.com ([165.225.203.62]) by smtp.googlemail.com with ESMTPSA id t17sm20628056wrx.82.2020.09.21.04.28.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Sep 2020 04:28:35 -0700 (PDT) Message-ID: <2f29372be8186f25222e370f5601019b4d95b7b3.camel@gmail.com> Subject: Re: [PATCH] PCI: kirin: Return -EPROBE_DEFER in case the gpio isn't ready From: Bean Huo To: Lorenzo Pieralisi Cc: songxiaowei@hisilicon.com, wangbinghui@hisilicon.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, beanhuo@micron.com Date: Mon, 21 Sep 2020 13:28:31 +0200 In-Reply-To: <20200921112209.GA2220@e121166-lin.cambridge.arm.com> References: <20200918123800.19983-1-huobean@gmail.com> <20200921112209.GA2220@e121166-lin.cambridge.arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-09-21 at 12:22 +0100, Lorenzo Pieralisi wrote: > > Fix the above issue by letting kirin_pcie_probe() return > > -EPROBE_DEFER in > > such a case. > > > > Fixes: 6e0832fa432e ("PCI: Collect all native drivers under > > drivers/pci/controller") > > This is certainly not the commit that triggered the issue so I would > remove it. Kirin maintainers are CC'ed, waiting for their ACK. > > Lorenzo Hi Lorenzo Thanks very much for your reply. It is true this is a bug which was introduced by the origin commit. It is ok for me to remove this fix tag. Thanks, Bean