Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 21 Sep 2020 13:44:03 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Wolfram Sang <wsa@the-dreams.de>,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 32/34] i2c: tegra: Clean up and improve comments
Message-ID: <20200921114403.GO3950626@ulmo>
References: <20200908224006.25636-1-digetx@gmail.com>
 <20200908224006.25636-33-digetx@gmail.com>
 <20200917123208.GK3515672@ulmo>
 <11a29706-0870-792e-d5d5-7c0d1f402281@gmail.com>
 <cbf6f8da-0e9e-3249-2173-bdccbf368bcb@gmail.com>
 <20200921114320.GN3950626@ulmo>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7gLe/sNPhR777EPF"
Content-Disposition: inline
In-Reply-To: <20200921114320.GN3950626@ulmo>
User-Agent: Mutt/1.14.6 (2020-07-11)
Precedence: bulk


--7gLe/sNPhR777EPF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 21, 2020 at 01:43:20PM +0200, Thierry Reding wrote:
> On Thu, Sep 17, 2020 at 06:17:39PM +0300, Dmitry Osipenko wrote:
> > 17.09.2020 18:02, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > > 17.09.2020 15:32, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > > ...
> > >>>  /**
> > >>> - * struct tegra_i2c_hw_feature : Different HW support on Tegra
> > >>> - * @has_continue_xfer_support: Continue transfer supports.
> > >>> + * struct tegra_i2c_hw_feature : per hardware generation features
> > >>
> > >> I think that space before ':' can go away. Although that's preexisti=
ng,
> > >> so could also be a separate patch, I guess.
> > >=20
> > > I haven't even noticed that!
> > >=20
> >=20
> > Wait, that ':' is used only for the struct description, hence it
> > actually looks natural in the code.
>=20
> What makes the struct description different from the field descriptions?
> A description list is basically:
>=20
>   <term>: <description>
>=20
> And it doesn't matter what exactly <term> is.

Anyway, like I said, this is preexisting, so we can always fix that up
in another patch:

Reviewed-by: Thierry Reding <treding@nvidia.com>

--7gLe/sNPhR777EPF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9okgMACgkQ3SOs138+
s6EmtBAAkfQ9fVhXgL1Kn6aZkejoutZrTxeIfbN6vwCo2rdm2HliMngdx5VEd/HR
BeicysE9y12BvO34KW0VVeF7YIPELrYf1V76ROQmLI3GSwFNZ+1i8K4ICtRAHN4D
RUd4aCiyKDpqwK7WVzdxAyIE53YCd+Lmx4K89s+o5eRc0/ncFv76sHwaVta9fvPa
f9Rh/s9ec3E8Z70VyC0dVubQ7SB+/OZgtrqq4UvKQB4bnkToaRWM5AHavGngesCN
DEl7fZmKzZ7jM/QpYEcMYk4SWjrOmduYiEhf0y+3GrRHj8FxVihfBhRwwbJRaaUR
j0exQgu+B1Yt2rE1ieW8wjYZR9S3qIE5OD3T0oz37AH4PUEOT9yn+ZhuujRr1gjb
ckXw3Md3cSVxGyQJUtWqzUAvF/zJR86AkkQIvxAr8ZjlYWRA9qsyL4VctdVCpmye
XE27ycAXmcYOOMlJFlbU7bDdDA30b5JWnubnIiZ1DdDPpOQBmmcNxL/eREl2sFBM
wONlkz5+IH6c/zIZOxJl+eWKU46du9S5Xr00XctA9zphWkzbKwllzOFUtJl7K4Il
Ro8hwWokfMKANk9KHY0K34MzHEDzW7ILLD8FYcYEJ/STWBAkh8b8IfuRGhcf6Rgt
GNLhLC1y0NP16rqKAe9+6T5ztUA4XaO01e70+Yxbzz+j0wCFTwI=
=a9jA
-----END PGP SIGNATURE-----

--7gLe/sNPhR777EPF--