Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3111250pxk; Mon, 21 Sep 2020 05:39:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrXuSKrLyYkWprCxScr+MAA2yhykRr2rMbzwZAz+DEkVEPVOsE5JtegBR0tbhdJ2qU2d2H X-Received: by 2002:a17:906:eb4d:: with SMTP id mc13mr49707723ejb.234.1600691987464; Mon, 21 Sep 2020 05:39:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600691987; cv=none; d=google.com; s=arc-20160816; b=AQt51dzSvkhUCSJubUELd0DBJOSDp88pwrx+vZm45PNTOzV5GYytOHOashQU1CUZJd S4hkZBRrcStzTzbSkfwvGXrX/9qvHB11BLuEEleb6lFNTJt5rXVe98LRaN/1BgUAifNi yVNA+cKHOwRB+kAjfCgU37Bm/8V1DuIKC1xcwxYBT+icVw6kFFbV0VmSDIvqfIvn+zZz hRfk92dow3CM+9Yy92bxED4ImKyAMm9dXY4nH4swZS0UqaPVdPgfx7BDZp+DQwZyrTQx BbcUuWJEPozASUzBUEIU+yTVqUxNa5l8/rh1EUqm3+PRuMEiMSiHhIRi7/E+/Cb4KpRj I6Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=LmrlyDSnunLPtHezBkJy3axjB4cP03nzw/xo10lxJWY=; b=mC/LwO5IsikPoDLyfrURSyHL8YX8pYd722iLolPq5R/Epmz+d/uK1Njlo7evHkdhWB 84ghgforFhBbMF8j/43oNdCpq+8+XDbh4vhfcBQpTWNqSEqgKZSmhCS/ml/YmXtGvUhW 8xOz4Ww8gfl2axEpouagM5OFUSUy4Dh+X6EwxEmcmfIVpS9xBlZmw8d6thP6jEpzeTiK re124lob8dAu+W60/NB65gKH4hTG2lv0i+NbAHWaN2PPv+KKsw0xgPXnTavbYviaQTs7 SVKJ6oQQv9NfTTtaxrdT7vB9/4fM1Coo/2oQnM/BxEY5g4+mRJwn09mPPtI5cnMZr/CA IPkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c5si8019851edv.513.2020.09.21.05.39.23; Mon, 21 Sep 2020 05:39:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726913AbgIUMfk (ORCPT + 99 others); Mon, 21 Sep 2020 08:35:40 -0400 Received: from mail.ispras.ru ([83.149.199.84]:43718 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgIUMfj (ORCPT ); Mon, 21 Sep 2020 08:35:39 -0400 X-Greylist: delayed 330 seconds by postgrey-1.27 at vger.kernel.org; Mon, 21 Sep 2020 08:35:38 EDT Received: from hellwig.intra.ispras.ru (unknown [10.10.2.182]) by mail.ispras.ru (Postfix) with ESMTPS id 75A3240D403E; Mon, 21 Sep 2020 12:30:07 +0000 (UTC) From: Evgeny Novikov To: Antti Palosaari Cc: Evgeny Novikov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] media: dvb-frontends: rtl2832_sdr: set error code in probe Date: Mon, 21 Sep 2020 15:30:06 +0300 Message-Id: <20200921123006.8016-1-novikov@ispras.ru> X-Mailer: git-send-email 2.16.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If rtl2832_sdr_probe() encounters an unsupported tuner it cleans up everything and returns 0. This can result in various bad things later. The patch sets the error code on the corresponding path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov --- drivers/media/dvb-frontends/rtl2832_sdr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-frontends/rtl2832_sdr.c index 720756728f2d..ef6feb299d46 100644 --- a/drivers/media/dvb-frontends/rtl2832_sdr.c +++ b/drivers/media/dvb-frontends/rtl2832_sdr.c @@ -1411,6 +1411,7 @@ static int rtl2832_sdr_probe(struct platform_device *pdev) default: v4l2_ctrl_handler_init(&dev->hdl, 0); dev_err(&pdev->dev, "Unsupported tuner\n"); + ret = -ENODEV; goto err_v4l2_ctrl_handler_free; } if (dev->hdl.error) { -- 2.26.2