Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3133286pxk; Mon, 21 Sep 2020 06:11:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyG+/bUo8Pq/CsGX+ccYMn2kK+t1+YtykYdQJNhTbDWoZ3TU7vL3r3U8N5vrl2WbvW/VpGO X-Received: by 2002:a17:906:fb04:: with SMTP id lz4mr7331487ejb.535.1600693882926; Mon, 21 Sep 2020 06:11:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600693882; cv=none; d=google.com; s=arc-20160816; b=al1ndkdzgDp3fNtzDd99fLaJozN3HgQXJriMpK+7qoubeMdC/utN1teMb2pwVJYAhv ZRHCRcHLHXgNRfDJstkKeALwKwbiwh/S76l/XxbA8pTDcBoSGtD94zyrxMGdxy6SDEpe sk4KhEnLLLgjwQ+4LXxVG57fH/2wyVoZFpzn4WTbYRzYimEIF9x/Hsjg4jjxrV7PrKiK gke/xoK7EBre4+1kxINWZUSWUrYZTW8fJaFJMV3Nzd4eCwEYOpfiA5yuYcEW7/1peuiQ 0IR3C+vmWLh6CvPOZXTuKXjRk0zis0TdEmvQyngXgnvVhzu0J6H5tbh8oAmturbg7TTa ecMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Z7Nhjr0UpNBmccKyS4Q6fNY4CmcPydjYn5NPGD0KTJM=; b=RLKk2J/4OqPxaYYxBSxIC2VAGnaM1ifD1McoIOBnDepvRCJCD5aD7tD7Omhg86rfXn X7oT7CXQOQ/9VqI9NUYfJh7jYteMsghe8SmjmFo8AxhE+ygwXosCBDTsspOyi6GzGkpS vKWTO8drYp5Bvc0nx8/3LJBqWJ56fX5vS+brL4Oy9DQxO9NG8j+PxU/HFUFLpUUGe/kB dYwiA3MxsgHRoDLaKNnq3DRIOHe8yJQixXZnUgE/2qHoLpn0AEM/JF2oJEq67GHoWXX3 F7QKq9rM62pdFuyK+WtjdyoJ09tg19eSNFUzJMUpYztXEpta/KUH5wz3DetDlxuiI/ba RzAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k4si8153117edq.351.2020.09.21.06.10.58; Mon, 21 Sep 2020 06:11:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbgIUNJw (ORCPT + 99 others); Mon, 21 Sep 2020 09:09:52 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:42056 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726417AbgIUNJv (ORCPT ); Mon, 21 Sep 2020 09:09:51 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 0226ED0F3774B90C5040; Mon, 21 Sep 2020 21:09:49 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Mon, 21 Sep 2020 21:09:41 +0800 From: Qinglang Miao To: Vishal Kulkarni CC: "David S. Miller" , Jakub Kicinski , , , Qinglang Miao Subject: [PATCH -next] chelsio: simplify the return expression of t3_ael2020_phy_prep() Date: Mon, 21 Sep 2020 21:10:05 +0800 Message-ID: <20200921131005.91054-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/chelsio/cxgb3/ael1002.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/ael1002.c b/drivers/net/ethernet/chelsio/cxgb3/ael1002.c index dadf11e3d..9d591f0dd 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/ael1002.c +++ b/drivers/net/ethernet/chelsio/cxgb3/ael1002.c @@ -815,17 +815,12 @@ static const struct cphy_ops ael2020_ops = { int t3_ael2020_phy_prep(struct cphy *phy, struct adapter *adapter, int phy_addr, const struct mdio_ops *mdio_ops) { - int err; - cphy_init(phy, adapter, phy_addr, &ael2020_ops, mdio_ops, SUPPORTED_10000baseT_Full | SUPPORTED_AUI | SUPPORTED_FIBRE | SUPPORTED_IRQ, "10GBASE-R"); msleep(125); - err = set_phy_regs(phy, ael2020_reset_regs); - if (err) - return err; - return 0; + return set_phy_regs(phy, ael2020_reset_regs); } /* -- 2.23.0