Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3146096pxk; Mon, 21 Sep 2020 06:27:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYuNwFKpEvtYZNoTrnmTx6SgUahxyRAA6VKmt89TfNj9mHfiyry39l4wyAeZw5CxM1MRLg X-Received: by 2002:aa7:dd01:: with SMTP id i1mr52877385edv.121.1600694878107; Mon, 21 Sep 2020 06:27:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600694878; cv=none; d=google.com; s=arc-20160816; b=qGK4VMUjOXHSI+Zxg7a+FvuPIGYQn6f4vKFb7Jpjy6Ha59fA4MT1jp7TCd8Tz97lQo XoxenOuHIYxt3hkIusFgBOfRTALfYNpxy6H4rSNoZyOa+TYTl8c6rmFrVPRQy93MC/dV PFgU877824rpx9NaDZEpmXzRzOSZeu9sIjrEWdsCB0bXOzldmkZTVoSOh1Oq/sUfoQtP gAGY4YE693THATa+2G8e8LlL79rlIP2Z+WamhdUiTf5Oig+GaXPUorG97pymKP94/mo9 Icg16yH8XvbicIapENSsI6MS2tOb65w8FJ5TT8DkfgkEibMdeXRhlHQ82gXF2dpGdr06 eiMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=lCGq811aci2eexCtd0VH6OcjlY39+kw3dJNWsMKi1cQ=; b=FT4b81KHYK+BM59FQHlCzp/GxwbOaKdlE3warW0t4Sv1uQ+FblLafsHgVzTMbWYshp MHiRrkej2D7SpB6u7dSSbYeDTyoQ5UbOLBKTwDC1qmcJWHHX//Pih3ZitnCjxzDdy3L6 N7gPuoldgIRh+qsXY7+RPOiKHP2exhl+WuDY6oB5r4nP4Mu/YJxD3KNZEAb6hNNjhrV+ /Q9Y7jD0XxAX7TfORzaDESgUVCqRkIZvQ6g+rl6nAtmugJqHI+J/Q7GACX54gIIj9k/7 7+hYNHYglL6ptdi8oARa1IDShZ96oj0Mdd94ioW3xWt69nt2hQoptpbQVvcVOJrnkffU Wzsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xnPuiqQb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si8325002edy.163.2020.09.21.06.27.34; Mon, 21 Sep 2020 06:27:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xnPuiqQb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727047AbgIUN0f (ORCPT + 99 others); Mon, 21 Sep 2020 09:26:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:48102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726932AbgIUN0e (ORCPT ); Mon, 21 Sep 2020 09:26:34 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B9712076E; Mon, 21 Sep 2020 13:26:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600694794; bh=vvbV0d1b9m6RLAHTC+GfWYs2Cg+CuDl9iFfAyv4zfok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xnPuiqQb5g5HgvW0Dczozc7y5dnQeN1FlC4k6x6a6cZV9e0uYv+s4HfgakYyYbYwt IkFWxbywc90mezKfMUieUzFjIeeclzxDNoBCgF5nw17Dhfpx8EPzltzW1eL8Ci1UHs FcQ+0/ijfWQyjAbbsPXdqdUiFFzh2JtsSfrqrlwA= Received: by pali.im (Postfix) id F257A7BF; Mon, 21 Sep 2020 15:26:31 +0200 (CEST) Date: Mon, 21 Sep 2020 15:26:31 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Konstantin Komarov Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, dsterba@suse.cz, aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org, joe@perches.com, mark@harmstone.com, nborisov@suse.com Subject: Re: [PATCH v5 08/10] fs/ntfs3: Add Kconfig, Makefile and doc Message-ID: <20200921132631.q6jfmbhqf6j6ay5t@pali> References: <20200911141018.2457639-1-almaz.alexandrovich@paragon-software.com> <20200911141018.2457639-9-almaz.alexandrovich@paragon-software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911141018.2457639-9-almaz.alexandrovich@paragon-software.com> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 11 September 2020 17:10:16 Konstantin Komarov wrote: > +Mount Options > +============= > + > +The list below describes mount options supported by NTFS3 driver in addition to > +generic ones. > + > +=============================================================================== > + > +nls=name This option informs the driver how to interpret path > + strings and translate them to Unicode and back. If > + this option is not set, the default codepage will be > + used (CONFIG_NLS_DEFAULT). > + Examples: > + 'nls=utf8' > + > +nls_alt=name This option extends "nls". It will be used to translate > + path string to Unicode if primary nls failed. > + Examples: > + 'nls_alt=cp1251' Hello! I'm looking at other filesystem drivers and no other with UNICODE semantic (vfat, udf, isofs) has something like nls_alt option. So do we really need it? And if yes, it should be added to all other UNICODE filesystem drivers for consistency. But I'm very sceptical if such thing is really needed. nls= option just said how to convert UNICODE code points for userpace. This option is passed by userspace (when mounting disk), so userspace already know what it wanted. And it should really use this encoding for filenames (e.g. utf8 or cp1251) which already told to kernel.