Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Varun Sethi <V.Sethi@nxp.com>, Leo Li <leoyang.li@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: RE: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds
 board
Thread-Topic: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds
 board
Thread-Index: AQHWgTuoJIcsrSh3jEy4wdu9ducPKqlZsQ4AgAY8A2CABORpAIAN438wgAB3wICAAAhv4A==
Date:   Mon, 21 Sep 2020 13:34:06 +0000
Message-ID: <AM7PR04MB6885E3EB822D59F2228DA4908E3A0@AM7PR04MB6885.eurprd04.prod.outlook.com>
References: <1599059610-7570-1-git-send-email-meenakshi.aggarwal@nxp.com>
 <1599059610-7570-2-git-send-email-meenakshi.aggarwal@nxp.com>
 <20200905075419.GN9261@dragon>
 <AM7PR04MB688571606382A8992C71E8E38E260@AM7PR04MB6885.eurprd04.prod.outlook.com>
 <20200912094913.GB25109@dragon>
 <AM7PR04MB6885EF94F69D741496AD9C838E3A0@AM7PR04MB6885.eurprd04.prod.outlook.com>
 <20200921130325.GA25428@dragon>
In-Reply-To: <20200921130325.GA25428@dragon>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d6d07dea-6efb-4b09-540b-08d85e3303b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 13:34:06.9624
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QyvUp8s1+iYtCiLThw8qsdF+S1SAewKOI3gbO/Cb2K128o06GBo5aRKuF50vqYRNWK5dw/n7xUyxJrxzF0oDtU8sUhzG8hqccPrgavpoLcU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6901
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ok, I will update the dts with your suggestions.

Thanks,
Meenakshi

> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Monday, September 21, 2020 6:33 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li
> <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei
> <ioana.ciornei@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com>
> Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162a=
qds
> board
>=20
> On Mon, Sep 21, 2020 at 06:00:53AM +0000, Meenakshi Aggarwal wrote:
> >
> >
> > > -----Original Message-----
> > > From: Shawn Guo <shawnguo@kernel.org>
> > > Sent: Saturday, September 12, 2020 3:19 PM
> > > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li
> > > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana
> > > Ciornei <ioana.ciornei@nxp.com>; Kuldeep Singh
> > > <kuldeep.singh@nxp.com>
> > > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for
> > > lx2162aqds board
> > >
> > > On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote:
> > > > > > +	sb_3v3: regulator-sb3v3 {
> > > > > > +		compatible =3D "regulator-fixed";
> > > > > > +		regulator-name =3D "MC34717-3.3VSB";
> > > > > > +		regulator-min-microvolt =3D <3300000>;
> > > > > > +		regulator-max-microvolt =3D <3300000>;
> > > > > > +		regulator-boot-on;
> > > > > > +		regulator-always-on;
> > > > >
> > > > > I do not see any point to have regulator-boot-on or
> > > > > regulator-always-on for a regulator that doesn't have on/off cont=
rol.
> > > > [Meenakshi Aggarwal] Properties are added to specify that platform
> > > > firmware's out of reset configuration enabled the regulator and
> > > > regulator
> > > should never be disabled or change its operative status.
> > >
> > > What I was wondering if how this regulator is enabled by firmware,
> > > by some GPIO control?  In that case, 'gpio' property should be there
> > > to describe the GPIO control.
> > >
> > [Meenakshi Aggarwal] Its not controlled by GPIO. Its gets power on with=
 board.
> > > >
> > > > Can you help in understanding why these optional properties cannot
> > > > be used together
> > >
> > > It's totally fine to use these properties together.  But if the
> > > regulator doesn't have on/off control, neither of them makes sense.
> > [Meenakshi Aggarwal] As per documentation, we should keep "
> > regulator-always-on " as per description, we Can remove " regulator-boo=
t-on"
> property from dts.
> >
> > regulator-always-on:
> >     description: boolean, regulator should never be disabled
>=20
> Again, the property is only meaningful for a regulator that can possibly =
be
> disabled.
>=20
> Shawn