Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbWHBWFZ (ORCPT ); Wed, 2 Aug 2006 18:05:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932251AbWHBWFZ (ORCPT ); Wed, 2 Aug 2006 18:05:25 -0400 Received: from smtp.osdl.org ([65.172.181.4]:2251 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932261AbWHBWFY (ORCPT ); Wed, 2 Aug 2006 18:05:24 -0400 Date: Wed, 2 Aug 2006 15:04:44 -0700 (PDT) From: Linus Torvalds To: Russell King cc: Dave Jones , "Rafael J. Wysocki" , Jesse Brandeburg , Andrew Morton , stern@rowland.harvard.edu, linux-kernel@vger.kernel.org, cpufreq@www.linux.org.uk Subject: Re: Linux v2.6.18-rc3 In-Reply-To: <20060802213834.GB17599@flint.arm.linux.org.uk> Message-ID: References: <20060731081112.05427677.akpm@osdl.org> <20060801215919.8596da9d.akpm@osdl.org> <4807377b0608021257p27882866i69a5a0a4a1f05dda@mail.gmail.com> <200608022216.54797.rjw@sisk.pl> <20060802202309.GD7173@flint.arm.linux.org.uk> <20060802203236.GC23389@redhat.com> <20060802205824.GA17599@flint.arm.linux.org.uk> <20060802213834.GB17599@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1115 Lines: 27 On Wed, 2 Aug 2006, Russell King wrote: > > > The serial layer should use set_termios() when users set the termios state > > (surprise surprise), not to emulate suspend/restore. > > Yes Linus, you're obviously right. Would you mind re-engineering this > while I'm away for the next few days. For _ALL_ serial drivers, not > just 8250. Thanks. The problem is that right now, the silly set_termios() call can be actively detrimental to sub-drivers that do this right. I suspect it would be a lot better to just fix a few major serial drivers (and yes, that means primarily 8250), and just force others to fix themselves as developers get around to it and care (in many cases they might not even do so). As it is, going to set_termios way is likely to just make things _worse_ in the long run, by just not letting the serial driver do what's sane. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/