Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932086AbWHBWgH (ORCPT ); Wed, 2 Aug 2006 18:36:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932095AbWHBWgH (ORCPT ); Wed, 2 Aug 2006 18:36:07 -0400 Received: from mx1.redhat.com ([66.187.233.31]:28341 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932086AbWHBWgF (ORCPT ); Wed, 2 Aug 2006 18:36:05 -0400 Date: Wed, 2 Aug 2006 18:36:04 -0400 From: Dave Jones To: Linux Kernel Subject: tty_io wtf. Message-ID: <20060802223604.GI3639@redhat.com> Mail-Followup-To: Dave Jones , Linux Kernel Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 27 I knew I'd regret digging in the tty code. Can someone enlighten me as to what this *should* be doing? int tty_insert_flip_string(struct tty_struct *tty, const unsigned char *chars, size_t size) { .... /* There is a small chance that we need to split the data over several buffers. If this is the case we must loop */ while (unlikely(size > copied)); return copied; } Looping I can understand, but forever ? Given we're not advancing 'copied', can we just kill that while loop? Or should we be changing it with each iteration? Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/