Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3204801pxk; Mon, 21 Sep 2020 07:50:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiabmA549g2dYjBPt+lMSwBCTvho/qnXOs9/4x7DPVJzqe/ow+MD2cpKv5MzRngJR0z3n2 X-Received: by 2002:a50:bf47:: with SMTP id g7mr46681edk.26.1600699810340; Mon, 21 Sep 2020 07:50:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600699810; cv=none; d=google.com; s=arc-20160816; b=gS6eEk4XIhO+6VQ8kCjT6UtDQArRd9SSWCyZd4Ff+FLrY+zmM5T2VfPb+NcmU/+m+n OhwGu7tg3PpAqeT1FZnxvDtwvfIaKQO5JxoR24J76BJ5GT9oi257ksMKhNVdYEy6HNGG zI4sEi9w/cJm2HKCRTlCKVEFZVqNIm6Vm0lSFWEzEftxW6jGUI3eaMlkWgtTOHgaxx30 BiuZ64U6MLNHtZ40m1o3poPtx+uCPl96h1I9wtLF4Ac1Yht94kQPLFdBBPkMUkHpQvjH Sta03u7lB57r2w5vWsNMiYACAG3mKQNN91fBH5srzwSQhB2D/Cg9IWKHsYNpdIWy2Io4 R26Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=abCRjC2mQUJtTw1U3F0L0SPhJyStF7Z8StOaSj6DWd0=; b=et3TtsaDWOf6bgdQw8TCAFU36iBinheny0itUdHkN1sioSfRQFKDBdFQmTT4+ZuICH ANRhgqkhvbOOtmbvVHua2urLCNUsNEd2Z9mh8AACh1qS0juEbkqjyqmR/tYreW1nmkCd sYJPpLBObE0IFVfT8Zhc8g6RpB006weoBVttI/FW2OKIB+7eKTwUxlvPoH+iZjEbE1mU w8kLtunnT7hlNniA8t00U+iaLasDuvFBt3m3qeWPR8p9hjmYoMMob1tN3/NMVBQzWAau N15HmSVQO3j20Y9446To4SJwcgjTpxxXGlDdyGVyMYZzdB3nxosoA5L63yxGEzNsczNL Rggw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nu21si7784339ejb.96.2020.09.21.07.49.46; Mon, 21 Sep 2020 07:50:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728238AbgIUOsv (ORCPT + 99 others); Mon, 21 Sep 2020 10:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727990AbgIUOsM (ORCPT ); Mon, 21 Sep 2020 10:48:12 -0400 Received: from smtp1.goneo.de (smtp1.goneo.de [IPv6:2001:1640:5::8:30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AF7AC0613D0 for ; Mon, 21 Sep 2020 07:48:12 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.goneo.de (Postfix) with ESMTP id 4165223F066; Mon, 21 Sep 2020 16:48:11 +0200 (CEST) X-Virus-Scanned: by goneo X-Spam-Flag: NO X-Spam-Score: -2.995 X-Spam-Level: X-Spam-Status: No, score=-2.995 tagged_above=-999 tests=[ALL_TRUSTED=-1, AWL=-0.095, BAYES_00=-1.9] autolearn=ham Received: from smtp1.goneo.de ([127.0.0.1]) by localhost (smtp1.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LrVNYQ6MSv6e; Mon, 21 Sep 2020 16:48:09 +0200 (CEST) Received: from lem-wkst-02.lemonage.de. (hq.lemonage.de [87.138.178.34]) by smtp1.goneo.de (Postfix) with ESMTPA id 028DB23F04B; Mon, 21 Sep 2020 16:48:08 +0200 (CEST) From: poeschel@lemonage.de To: Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org (open list) Cc: Lars Poeschel Subject: [PATCH v2 27/32] auxdisplay: remove naive display clear impl Date: Mon, 21 Sep 2020 16:46:39 +0200 Message-Id: <20200921144645.2061313-28-poeschel@lemonage.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921144645.2061313-1-poeschel@lemonage.de> References: <20191016082430.5955-1-poeschel@lemonage.de> <20200921144645.2061313-1-poeschel@lemonage.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars Poeschel Remove the naive (character after character from upper left to lower right) display clear implementation in charlcd_clear_fast. It was a fallback and we fall back to using the clear_display implementation instead. Signed-off-by: Lars Poeschel --- drivers/auxdisplay/charlcd.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c index ef448c42abbd..0137e741c5bb 100644 --- a/drivers/auxdisplay/charlcd.c +++ b/drivers/auxdisplay/charlcd.c @@ -127,21 +127,13 @@ static void charlcd_print(struct charlcd *lcd, char c) static void charlcd_clear_fast(struct charlcd *lcd) { - int x, y; - if (lcd->ops->clear_fast) lcd->ops->clear_fast(lcd); - else { - for (y = 0; y < lcd->height; y++) { - lcd->addr.x = 0; - lcd->addr.y = y; - lcd->ops->gotoxy(lcd); - for (x = 0; x < lcd->width; x++) - lcd->ops->print(lcd, ' '); - } + else + lcd->ops->clear_display(lcd); - lcd->ops->home(lcd); - } + lcd->addr.x = 0; + lcd->addr.y = 0; } /* -- 2.28.0