Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3206095pxk; Mon, 21 Sep 2020 07:52:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrzm2KEFWAXp6kJSy2O5PJgXxtEP0BKD8XFHEEIy+La44QE575eqNXvsPeLES0+sCZ2UTz X-Received: by 2002:a17:906:cf9d:: with SMTP id um29mr49792803ejb.74.1600699926484; Mon, 21 Sep 2020 07:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600699926; cv=none; d=google.com; s=arc-20160816; b=Bx1Hl3Pgbkyb8BzqhQKjJ4aZI4F7BHAdJPnwVVOmHbf3aKYFpdf6omGJj1LCrY+TOI smpz9LaVD8mnK7+N9YRuATQDV3nUiQT1jPQKoByxJEzR532Wdcj8hwpaiqsCSrJGh4Z+ yUTy1u6gUw2qI4fwJgS+epINz/wFjbaIVbYdTm9xmSm0NgUIJziZcSdhuh/du2ubrKws AmGSpaf84U9vzin86PR4ZgG5PhZNmG4MS4BhLRMmm8jDmRiu74F9HSihOQPz/po7d+dC /t5lfQLoK3BNjEYDLRtutCmoF3tjkBadliH24RrXEWfdRLgkhiz5MRHWyn1qPfZsGRsE he4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/u8ji61jGBjjoHN9RxC1CBXN1Xpb36z0yhR4UyXnpaE=; b=gjhWgWNXzPe3dkpjTdW2JH2IOZvDFfMaGy7MUw40ZY+HI9d7RMeqiiVHm11NHQJ1F9 fM3+wK8/cvIDA2ari9gw8Xr2L5J6UqBusW2+RDgB55xsx+vH2DaFWbrAlP520/fkPIG5 76X4sJHru5jcJzps1FQK4V+yp515MwFk47R1A0c57CIruPsCmi9uK+qZjZuIFg8MqNpn iwE49DV9VotJeE2omqkcyrYhcTtYgyjfpmUT71kHKinImVtl7mFBV5k+NwEnrcthNPsR 0N2fDIaztlebf+ZDDokTc/MIKCagyi2Eol6aAZi/l37T5XLUujFSrzkA4QCn06Nh0avo gecQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu20si8326949edb.311.2020.09.21.07.51.42; Mon, 21 Sep 2020 07:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728222AbgIUOtE (ORCPT + 99 others); Mon, 21 Sep 2020 10:49:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728059AbgIUOsM (ORCPT ); Mon, 21 Sep 2020 10:48:12 -0400 Received: from smtp1.goneo.de (smtp1.goneo.de [IPv6:2001:1640:5::8:30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21704C0613CF for ; Mon, 21 Sep 2020 07:48:12 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.goneo.de (Postfix) with ESMTP id 0940623F13F; Mon, 21 Sep 2020 16:48:11 +0200 (CEST) X-Virus-Scanned: by goneo X-Spam-Flag: NO X-Spam-Score: -2.996 X-Spam-Level: X-Spam-Status: No, score=-2.996 tagged_above=-999 tests=[ALL_TRUSTED=-1, AWL=-0.096, BAYES_00=-1.9] autolearn=ham Received: from smtp1.goneo.de ([127.0.0.1]) by localhost (smtp1.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ssxE-O_eCNgY; Mon, 21 Sep 2020 16:48:09 +0200 (CEST) Received: from lem-wkst-02.lemonage.de. (hq.lemonage.de [87.138.178.34]) by smtp1.goneo.de (Postfix) with ESMTPA id 6EF0123F06F; Mon, 21 Sep 2020 16:48:09 +0200 (CEST) From: poeschel@lemonage.de To: Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org (open list) Cc: Lars Poeschel Subject: [PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast Date: Mon, 21 Sep 2020 16:46:40 +0200 Message-Id: <20200921144645.2061313-29-poeschel@lemonage.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921144645.2061313-1-poeschel@lemonage.de> References: <20191016082430.5955-1-poeschel@lemonage.de> <20200921144645.2061313-1-poeschel@lemonage.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars Poeschel We remove the hd44780_clear_fast (display) clear implementation. charlcd will fall back to use hd44780_common_clear_display then, which is much much faster. Signed-off-by: Lars Poeschel --- drivers/auxdisplay/hd44780.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c index 207ed23e02ce..2e5e7c993933 100644 --- a/drivers/auxdisplay/hd44780.c +++ b/drivers/auxdisplay/hd44780.c @@ -38,18 +38,6 @@ struct hd44780 { struct gpio_desc *pins[PIN_NUM]; }; -static void hd44780_clear_fast(struct charlcd *lcd) -{ - struct hd44780_common *hdc = lcd->drvdata; - int pos; - - hd44780_common_home(lcd); - for (pos = 0; pos < min(2, lcd->height) * hdc->hwidth; pos++) - hd44780_common_print(lcd, ' '); - - hd44780_common_home(lcd); -} - static void hd44780_backlight(struct charlcd *lcd, enum charlcd_onoff on) { struct hd44780_common *hdc = lcd->drvdata; @@ -137,7 +125,6 @@ static void hd44780_write_data_gpio8(struct hd44780_common *hdc, int data) } static const struct charlcd_ops hd44780_ops_gpio8 = { - .clear_fast = hd44780_clear_fast, .backlight = hd44780_backlight, .print = hd44780_common_print, .gotoxy = hd44780_common_gotoxy, @@ -194,7 +181,6 @@ static void hd44780_write_data_gpio4(struct hd44780_common *hdc, int data) } static const struct charlcd_ops hd44780_ops_gpio4 = { - .clear_fast = hd44780_clear_fast, .backlight = hd44780_backlight, .print = hd44780_common_print, .gotoxy = hd44780_common_gotoxy, -- 2.28.0