Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3206851pxk; Mon, 21 Sep 2020 07:53:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWd3IXXT+vtAiWAAavsiJpyYAFwzhjVYZwMi2RD4hk9vujWk38fRAc/krh+CrfbeI1y994 X-Received: by 2002:a17:906:3e0c:: with SMTP id k12mr49692557eji.189.1600699994849; Mon, 21 Sep 2020 07:53:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600699994; cv=none; d=google.com; s=arc-20160816; b=EIAB46I09DAIyJxX+g3e9KHk1BI1n7rGNFRHTihFbALLfJi940Dtl0kNQCckJm0T37 OYU7428AjSXJCstoBVPaDWcKyNyxxkS1d9pxgN97FtdkKJmR2EQyzw62r14dy9cg3OO8 rmWh3rgbFLPaxPaaMp/g0jyPCaUx1jB9umr6xY5TwruX28ib+Os74hU305Cir/RT5lO6 ugbegF7YBClDq9gGqpzxq5WptNUto0Z2KDGQWW+vcYnB1BJqbH3d1OSsJIPkp3DtZQju OFfnDgR6qcXyf0070QkySZhHKyoI4e9dtn1dUg+0b41wm1LOGEhmn6lA82rcrsLJipzt Q6Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mzOufrHBT2mNOD2Dznteh+ghCF8kY6G+59qBEtyDVFQ=; b=PanLGKlS79KGhMKd/qxQtp3xJYm0rIToVkbKR8EpJ/IuD44r4neD1TvucfCdgPxJt+ tND8Q/7+py2HLkctFv3FvLpw5OkmGLmbLjsa73onQ1eyJn9XEqL6MMv7jGak8lNctflg mwE2oDQ7U13zTV3IF/7FNq8U+06kOwO/g7bkUNHljXMjAS7Phi5bm+yC5V4YypGdsD6/ FylwnOCA+9WS5HsYKLeFACUAUkkD0OQ2JIfvvIRbN+XlZ5J+X99TNPKfhRrzMBdfsAsD PulZBT4vruCWT0i3jAOWTqFdiunWfOq1TyRQwMT4yRM3gCZ5lwYwy82fXUrD0pIwafBl mZyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si9329091ejg.582.2020.09.21.07.52.51; Mon, 21 Sep 2020 07:53:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728219AbgIUOt0 (ORCPT + 99 others); Mon, 21 Sep 2020 10:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728013AbgIUOsI (ORCPT ); Mon, 21 Sep 2020 10:48:08 -0400 Received: from smtp1.goneo.de (smtp1.goneo.de [IPv6:2001:1640:5::8:30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2DCDC0613D0 for ; Mon, 21 Sep 2020 07:48:07 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.goneo.de (Postfix) with ESMTP id 8BE5F23F0A3; Mon, 21 Sep 2020 16:48:06 +0200 (CEST) X-Virus-Scanned: by goneo X-Spam-Flag: NO X-Spam-Score: -2.999 X-Spam-Level: X-Spam-Status: No, score=-2.999 tagged_above=-999 tests=[ALL_TRUSTED=-1, AWL=-0.099, BAYES_00=-1.9] autolearn=ham Received: from smtp1.goneo.de ([127.0.0.1]) by localhost (smtp1.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8aDtErHmpzGd; Mon, 21 Sep 2020 16:48:04 +0200 (CEST) Received: from lem-wkst-02.lemonage.de. (hq.lemonage.de [87.138.178.34]) by smtp1.goneo.de (Postfix) with ESMTPA id CBB6B23F06F; Mon, 21 Sep 2020 16:48:04 +0200 (CEST) From: poeschel@lemonage.de To: Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org (open list) Cc: Lars Poeschel Subject: [PATCH v2 20/32] auxdisplay: cleanup unnecessary hd44780 code in charlcd Date: Mon, 21 Sep 2020 16:46:32 +0200 Message-Id: <20200921144645.2061313-21-poeschel@lemonage.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921144645.2061313-1-poeschel@lemonage.de> References: <20191016082430.5955-1-poeschel@lemonage.de> <20200921144645.2061313-1-poeschel@lemonage.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars Poeschel This cleans up now unnecessary hd44780 specific code from charlcd. We obsoleted this with the last three patches. So another chunk of hd44780 code can be dropped. Signed-off-by: Lars Poeschel --- drivers/auxdisplay/charlcd.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c index b099897e101b..c04aaa4d66a5 100644 --- a/drivers/auxdisplay/charlcd.c +++ b/drivers/auxdisplay/charlcd.c @@ -26,11 +26,6 @@ #define LCD_BL_TEMPO_PERIOD 4 /* LCD commands */ -#define LCD_CMD_DISPLAY_CTRL 0x08 /* Display control */ -#define LCD_CMD_DISPLAY_ON 0x04 /* Set display on */ -#define LCD_CMD_CURSOR_ON 0x02 /* Set cursor on */ -#define LCD_CMD_BLINK_ON 0x01 /* Set blink on */ - #define LCD_CMD_FUNCTION_SET 0x20 /* Set function */ #define LCD_CMD_DATA_LEN_8BITS 0x10 /* Set data length to 8 bits */ #define LCD_CMD_TWO_LINES 0x08 /* Set to two display lines */ @@ -419,17 +414,7 @@ static inline int handle_lcd_special_code(struct charlcd *lcd) if (oldflags == priv->flags) return processed; - /* check whether one of B,C,D flags were changed */ - if ((oldflags ^ priv->flags) & - (LCD_FLAG_B | LCD_FLAG_C | LCD_FLAG_D)) - /* set display mode */ - hdc->write_cmd(hdc, - LCD_CMD_DISPLAY_CTRL | - ((priv->flags & LCD_FLAG_D) ? LCD_CMD_DISPLAY_ON : 0) | - ((priv->flags & LCD_FLAG_C) ? LCD_CMD_CURSOR_ON : 0) | - ((priv->flags & LCD_FLAG_B) ? LCD_CMD_BLINK_ON : 0)); - /* check whether one of F,N flags was changed */ - else if ((oldflags ^ priv->flags) & (LCD_FLAG_F | LCD_FLAG_N)) + if ((oldflags ^ priv->flags) & (LCD_FLAG_F | LCD_FLAG_N)) hdc->write_cmd(hdc, LCD_CMD_FUNCTION_SET | ((hdc->ifwidth == 8) ? LCD_CMD_DATA_LEN_8BITS : 0) | -- 2.28.0