Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 02/32] auxdisplay: Introduce hd44780_common.[ch]
To:     poeschel@lemonage.de,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
        Willy Tarreau <willy@haproxy.com>,
        Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20191016082430.5955-1-poeschel@lemonage.de>
 <20200921144645.2061313-1-poeschel@lemonage.de>
 <20200921144645.2061313-3-poeschel@lemonage.de>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <7239765f-bcbe-2149-e38a-bd03e33a7099@infradead.org>
Date:   Mon, 21 Sep 2020 08:30:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200921144645.2061313-3-poeschel@lemonage.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 9/21/20 7:46 AM, poeschel@lemonage.de wrote:
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 81757eeded68..153fa426ae7d 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -14,12 +14,31 @@ menuconfig AUXDISPLAY
>  
>  	  If you say N, all options in this submenu will be skipped and disabled.
>  
> +config CHARLCD
> +	tristate "Character LCD core support" if COMPILE_TEST
> +	help
> +	  This is the base system for character based lcd displays.

	                              character-based LCD

> +	  It makes no sense to have this alone, you select your display driver
> +	  and if it needs the charlcd core, it will select it automatically.
> +	  This is some character lcd core interface that multiple drivers can

	                         LCD

> +	  use.
> +
> +config HD44780_COMMON
> +	tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST
> +	help
> +	  This is a module with the common symbols for HD44780 (and compatibles)
> +	  displays. This is the code that multiple other modules use. It is not
> +	  useful alone. If you have some sort of HD44780 compatible display,
> +	  you very likely use this. It is selected automatically by selecting
> +	  your concrete display.


thanks.
-- 
~Randy