Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 33/33] auxdisplay: add a driver for lcd2s character
 display
To:     poeschel@lemonage.de,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20191016082430.5955-1-poeschel@lemonage.de>
 <20200921144645.2061313-1-poeschel@lemonage.de>
 <20200921144645.2061313-34-poeschel@lemonage.de>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <775088e0-8873-3f6d-4947-95ffb763ef39@infradead.org>
Date:   Mon, 21 Sep 2020 08:33:32 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200921144645.2061313-34-poeschel@lemonage.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/21/20 7:46 AM, poeschel@lemonage.de wrote:
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 153fa426ae7d..9c338af59589 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -173,6 +173,17 @@ config HT16K33
>  	  Say yes here to add support for Holtek HT16K33, RAM mapping 16*8
>  	  LED controller driver with keyscan.
>  
> +config LCD2S
> +	tristate "lcd2s 20x4 character display over I2C console"
> +	depends on I2C
> +	select CHARLCD
> +	default n

Drop "default n". That is already the default.

> +	help
> +	  This is a driver that lets you use the lcd2s 20x4 character display
> +	  from modtronix engineering as a console output device. The display

	       Modtronix

> +	  is a simple single color character display. You have to connect it
> +	  to an I2C bus.

thanks.
-- 
~Randy