Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: l9NNHBS5tCx5RQKnVtB8UJQv90hIXDA+L0Eg5AWrBE6xOmTwxJyn0t8LVf2kD0dCT9j+nbP5CH
 JP75pwT6jdIQ==
IronPort-SDR: 7ad+1nVDeDsYLl6lKHH1rGCwQwYKodf6VPRjBm/yFyFSLtsis/mfLXUp/eAVjyVUeMIpo3IS3N
 KGIFQ3VA2HrQ==
From:   "Wu, Hao" <hao.wu@intel.com>
To:     Liu Shixin <liushixin2@huawei.com>, Tom Rix <trix@redhat.com>,
        "Moritz Fischer" <mdf@kernel.org>
CC:     "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] fpga: dfl: simplify the return expression of
 fme_perf_pmu_register
Thread-Topic: [PATCH -next] fpga: dfl: simplify the return expression of
 fme_perf_pmu_register
Thread-Index: AQHWj+2UJse7LCHF60irHtKEohVbWKlzOYfg
Date:   Mon, 21 Sep 2020 15:36:03 +0000
Message-ID: <DM6PR11MB3819DE1E7F2FF14DF12C5D48853A0@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20200921082433.2591305-1-liushixin2@huawei.com>
In-Reply-To: <20200921082433.2591305-1-liushixin2@huawei.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fa2f4b0a-af52-4ee0-79b3-08d85e440c8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 15:36:03.2155
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p3XXqRptSA6GesVIES4/fGjSQurc1nAEqQq/+VP/oyA3R9hLQyE7dMbNY2lJjUh4yaQ4lVJfp0zx6ncvO4Y2jA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4644
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH -next] fpga: dfl: simplify the return expression of
> fme_perf_pmu_register
>=20
> Simplify the return expression.
>=20
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>

Looks good to me.

Acked-by: Wu Hao <hao.wu@intel.com>

Thanks
Hao

> ---
>  drivers/fpga/dfl-fme-perf.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>=20
> diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c
> index 531266287eee..e881fbe6d838 100644
> --- a/drivers/fpga/dfl-fme-perf.c
> +++ b/drivers/fpga/dfl-fme-perf.c
> @@ -906,7 +906,6 @@ static int fme_perf_pmu_register(struct
> platform_device *pdev,
>  {
>  	struct pmu *pmu =3D &priv->pmu;
>  	char *name;
> -	int ret;
>=20
>  	spin_lock_init(&priv->fab_lock);
>=20
> @@ -926,11 +925,7 @@ static int fme_perf_pmu_register(struct
> platform_device *pdev,
>=20
>  	name =3D devm_kasprintf(priv->dev, GFP_KERNEL, "dfl_fme%d", pdev-
> >id);
>=20
> -	ret =3D perf_pmu_register(pmu, name, -1);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return perf_pmu_register(pmu, name, -1);
>  }
>=20
>  static void fme_perf_pmu_unregister(struct fme_perf_priv *priv)
> --
> 2.25.1