Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] phy: fix USB_LGM_PHY warning & build errors
From:   Randy Dunlap <rdunlap@infradead.org>
To:     LKML <linux-kernel@vger.kernel.org>,
        USB list <linux-usb@vger.kernel.org>
Cc:     Li Yin <yin1.li@intel.com>,
        Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <d1dd0ddd-3143-5777-1c63-195e1a32f237@infradead.org>
Message-ID: <cb3b277e-109d-82c5-9dec-153b4e035c2a@infradead.org>
Date:   Mon, 21 Sep 2020 08:45:01 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <d1dd0ddd-3143-5777-1c63-195e1a32f237@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Ping.  Still seeing this in linux-next.

On 9/17/20 10:51 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix a Kconfig warning that is causing lots of build errors
> when USB_SUPPORT is not set.
> 
> USB_PHY depends on USB_SUPPORT but "select" doesn't care about
> dependencies, so this driver should also depend on USB_SUPPORT.
> It should not select USB_SUPPORT.
> 
> WARNING: unmet direct dependencies detected for USB_PHY
>   Depends on [n]: USB_SUPPORT [=n]
>   Selected by [m]:
>   - USB_LGM_PHY [=m]
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Li Yin <yin1.li@intel.com>
> Cc: Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> ---
>  drivers/phy/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20200917.orig/drivers/phy/Kconfig
> +++ linux-next-20200917/drivers/phy/Kconfig
> @@ -51,6 +51,7 @@ config PHY_XGENE
>  
>  config USB_LGM_PHY
>  	tristate "INTEL Lightning Mountain USB PHY Driver"
> +	depends on USB_SUPPORT
>  	select USB_PHY
>  	select REGULATOR
>  	select REGULATOR_FIXED_VOLTAGE
> 


-- 
~Randy