Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3287930pxk; Mon, 21 Sep 2020 09:45:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQYlpdFt6kKOlgkfs+vUuYp/rJ2K2UhvIauwrltyXcl52apXk9OZgi3rq1Hy8g+AitMBra X-Received: by 2002:a17:906:4c84:: with SMTP id q4mr288675eju.525.1600706744987; Mon, 21 Sep 2020 09:45:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600706744; cv=none; d=google.com; s=arc-20160816; b=Xe4on0k4hO7yDXvSUpOMQZXJTuKVQ7Huza3VMTiWG5WbxgpQphdrQaYHUhIVEOYCmr BlDRvTmFMDMKno+e6bRtxncfSq/tS3yslLyPXqVuq30gVSQr7qq1IVM7t6i5OXbLhojj EoLcrtEvGvbJv8uat1/yK61k8+0kZy2Z7uls4TvO1T5xy2R/jxvarMKuIedYH56zM/x6 l0KDeN7mXSK921dIeZLBMqlp6COKhemayLzxK1uONYzSEUJbqW5XmRXSlbA5JfXCN/q2 TYXnrx2PHL9Z5jDRdsx8EfmceTGxMnfs+y1tepE/7eKGfRmK4MqkLDfoOigBKHMhm81M z7+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=T+dLklyKt9Nm5aLvl9yXFtv0RujsGI9uDgv+AeZfpLw=; b=RNVkDwmM+R8C0kkJ7Q700CUrNhE/qkO4hTkhlm7Dr23eeBA9c/ioI0aJxMQNQXePig j476d3ekRPq31fwckHFOmDA6Exuwarisw2axTxKeRV3y3jDZygdYfPudPVg1AybVt+F9 9gcOWM0jISpCOkd6c3WgvJEeGtXX0PIMQI2HFuqQe+YSJY3fnfI33rtKfF/L14Y18Jft hzZ+dFC8jwJH0rd4YTQgk7DZBg1vXcCIj6WOa4BgrU1atj27qvdfrPDPiINyJQ3k7UEX uT6JDAVFqh4BvuY8fuplcsdvS3ZrfTL34JwTwCg3+g2/pwUo6kpZGFRbk224dOkYYlaD wBVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uwlNpo5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si8206863edr.99.2020.09.21.09.45.21; Mon, 21 Sep 2020 09:45:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uwlNpo5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729431AbgIUQlj (ORCPT + 99 others); Mon, 21 Sep 2020 12:41:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:44494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728929AbgIUQlJ (ORCPT ); Mon, 21 Sep 2020 12:41:09 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 662AD23976; Mon, 21 Sep 2020 16:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600706469; bh=jjgft5yC6WxzGjBIq3kaowD3BfwEqjnNYAh6r6wFbMo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uwlNpo5fC+kr0Tyk9NKU8sBV+vpUR5X5DtHfDQfaD72fyTUDkUkKBaKSLpNvggtvb O7DdAiq2ubKbfU26qrc/Wh52ZKDJ06jreAFOGVOwDX5xUTbtoP1OWakg5KjpHeL+XK 7XwAvVOBgPaHRZpbXNFHSgdV2Tan29acUCZNUBzw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haiyang Zhang , "David S. Miller" Subject: [PATCH 4.19 08/49] hv_netvsc: Remove "unlikely" from netvsc_select_queue Date: Mon, 21 Sep 2020 18:27:52 +0200 Message-Id: <20200921162035.038066716@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921162034.660953761@linuxfoundation.org> References: <20200921162034.660953761@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang commit 4d820543c54c47a2bd3c95ddbf52f83c89a219a0 upstream. When using vf_ops->ndo_select_queue, the number of queues of VF is usually bigger than the synthetic NIC. This condition may happen often. Remove "unlikely" from the comparison of ndev->real_num_tx_queues. Fixes: b3bf5666a510 ("hv_netvsc: defer queue selection to VF") Signed-off-by: Haiyang Zhang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -378,7 +378,7 @@ static u16 netvsc_select_queue(struct ne } rcu_read_unlock(); - while (unlikely(txq >= ndev->real_num_tx_queues)) + while (txq >= ndev->real_num_tx_queues) txq -= ndev->real_num_tx_queues; return txq;