Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3297126pxk; Mon, 21 Sep 2020 09:59:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymegNdNZdyCZx16oasO8QUDjENj4+ubZJzWeIp9JXjR6Cciam9S4BVRHaZ+jvUmWv8wACz X-Received: by 2002:a17:906:8258:: with SMTP id f24mr328785ejx.551.1600707568458; Mon, 21 Sep 2020 09:59:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600707568; cv=none; d=google.com; s=arc-20160816; b=KT2RXw0Pv1bI6HnuLVlHe6wZZwPI8XmS73eJ4NL3D5xB4PoIQbWGMJobY1i5gjjwZw biCFg0WUgjQDMbPkMifitkXjeEE8yNG5a0T8xfrSSFdqDdy4J75QbYNTNQ4Ks/d7wFnZ SiE5HREI5hb2BHeKusAT/5yX6+G/MGFFRaTPd+k3sbFclZPpr1ssioUQYJQNSPt2h2oN ih+xnPVNJIsJ1/7k02y4CERyBvJ37O1VOpOLIYSwMVQDMBfRtxdMqEaBZ7y2FI1PiQtE RryvRqJTPOrpFsdvBTPAGfBE1w/lKuQ8M6HTgzICVONyS7kUurhrLsyJ9UQDcTT0PQty ivUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=2svepaX7boXDeH34Dd9Kc8upuqhwhKdD9idkn8RtmXU=; b=AwCfAsjwnzIDE0/Kj0y4F+/Iu+OTJNe4E8mVfGviog+GDl02szRfavjUaz5p9WE2jb 3WCsToz2zoLO3kEeBw4K8Py8WIdkrwsQADNC6B59WPeMms4cbC2CDlaRmngDBJVLdKTG 17aUuW4RjNp97whZruo3hJ2esRQiK3tMpMfH5yQYZywoVqhQo4HRPry8lZGklKEDYA3V YkR29JbmcYCbAJiHiGQy/L4dYYCt5HsUX48DeBDTFT+jg3qDe1p3Jpi9GadXBdU4kPYi yVtc/af93toQV4r97HIn+s3rzcv/J814bPBg0C0qiMhB0O3LdfGPNEGSHbmDTDK9afFL 9CSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b23si8510416edx.34.2020.09.21.09.59.04; Mon, 21 Sep 2020 09:59:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730110AbgIUQ4J (ORCPT + 99 others); Mon, 21 Sep 2020 12:56:09 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:39498 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730032AbgIUQz7 (ORCPT ); Mon, 21 Sep 2020 12:55:59 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 1781DFB04; Mon, 21 Sep 2020 18:55:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wd294yyf5vT4; Mon, 21 Sep 2020 18:55:56 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 0A872457CE; Mon, 21 Sep 2020 18:55:52 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v1 1/3] drm/panel: mantix: Don't dereference NULL mode Date: Mon, 21 Sep 2020 18:55:50 +0200 Message-Id: X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't dereference mode which was just NULL checked. Signed-off-by: Guido Günther Reported-by: Dan Carpenter --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c index 3482e28e30fc..4a7fbf64bb7a 100644 --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c @@ -204,7 +204,7 @@ static int mantix_get_modes(struct drm_panel *panel, if (!mode) { dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n", default_mode.hdisplay, default_mode.vdisplay, - drm_mode_vrefresh(mode)); + drm_mode_vrefresh(&default_mode)); return -ENOMEM; } -- 2.26.2