Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3300166pxk; Mon, 21 Sep 2020 10:03:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyA4H84DsPMLGuw5ReuSHudaJJBkLNtNl4ypi+n6TZkuhGcYarVD/Drde+2XjP1IF1czdtU X-Received: by 2002:a17:906:b097:: with SMTP id x23mr392378ejy.21.1600707789974; Mon, 21 Sep 2020 10:03:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600707789; cv=none; d=google.com; s=arc-20160816; b=PQasZ6gqDDkJgZoJuh6vb/iDQSnpJEDjgFHGJSUlov+B4EEUPUy//o0DSWl8POQ7eZ 2Pl4/ViD/lyBbGIOD2WIO94pjE9JmMNPN3b02O5DvDhzxVuReCsoL1N100W2r8HumQnL oy9tP1lDxUVvIG1TR9Fx6cWg4/vtdrCitDvNmfLqUNU1XTZZBQrqOCMam0z6l2uQ1sFz f4s97iwrmZmH/3ldWyUkE+5wZ81TDbAFzEvA7EDzIx07uslIl5HgXOHvbDgmgSu+fxKB CKCYdrOCFUlNwVW5DdwlgjNAJrtF3OjQMWymoenfN6fgNRefT+oX9VhNsiPbQbjWNw+e ypuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3mCfi/5Wi68yJ180y+ObJPb4Q61qwM/IHFRaVNQg+QI=; b=AqubKpK+L8DIqao1s5iVBqAvSgvV95y8t3ztEwE0clr4gjajyt4C5QrvHKEIxpYzqZ 6u6je4HA07kDQmNqwkK+4scbSyfhAwHAp4/YcurBFnWxA+9daz8O+jU46CUhEWnagATP y+WZ3wj1quy3mm3H4y0rrmwjtIcoduncz41K25aEzQQNC7dLgvdcIPUUTP3HwjITxnun LYmXdBY6oH8UH+PMsHTAz6bXmEI5ZZTGlZrQfI1oP9smoser2+oMHjCAYbItb8HlkXv2 XpuHYtj2dBpUfGKX7ZyoQ8T01aNNwTF3ONmsAb6ofzxXqX4lgm+V33gpLwfA8MFFUFKP jC2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yCH7IuBY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c24si8703520edw.144.2020.09.21.10.02.44; Mon, 21 Sep 2020 10:03:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yCH7IuBY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbgIURBq (ORCPT + 99 others); Mon, 21 Sep 2020 13:01:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:40676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728110AbgIUQjK (ORCPT ); Mon, 21 Sep 2020 12:39:10 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C68EA206DC; Mon, 21 Sep 2020 16:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600706344; bh=oF2oOhr7yLJCocgLQji2YvNsjF6h1GZ2XlmT8LdVhu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yCH7IuBYRG08BdpGmNK2QkQ1lTenRCq5GPTetQRBeRtSq0mpMBHWoGatLOmkPdve+ BUsY1T/4DeWjYDuMnTp/CtbY5Oor6eG2MjE1ssFDJj7lSnWT/vXq1YP0pbE/QDMZ2F gBOB6NEw23qS6KzAJ969HI4XrPYm8bIM0luwgySc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haiyang Zhang , "David S. Miller" Subject: [PATCH 4.14 63/94] hv_netvsc: Remove "unlikely" from netvsc_select_queue Date: Mon, 21 Sep 2020 18:27:50 +0200 Message-Id: <20200921162038.432030939@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921162035.541285330@linuxfoundation.org> References: <20200921162035.541285330@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang commit 4d820543c54c47a2bd3c95ddbf52f83c89a219a0 upstream. When using vf_ops->ndo_select_queue, the number of queues of VF is usually bigger than the synthetic NIC. This condition may happen often. Remove "unlikely" from the comparison of ndev->real_num_tx_queues. Fixes: b3bf5666a510 ("hv_netvsc: defer queue selection to VF") Signed-off-by: Haiyang Zhang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -365,7 +365,7 @@ static u16 netvsc_select_queue(struct ne } rcu_read_unlock(); - while (unlikely(txq >= ndev->real_num_tx_queues)) + while (txq >= ndev->real_num_tx_queues) txq -= ndev->real_num_tx_queues; return txq;