Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3328907pxk; Mon, 21 Sep 2020 10:45:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiNoqby8TfFnfkKiqkxUKRYb0AP13rJ3wjnJlYNbIMyY/ac1SfBB8TLYGx1uie6qwYf802 X-Received: by 2002:a50:9b19:: with SMTP id o25mr62425edi.340.1600710312898; Mon, 21 Sep 2020 10:45:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600710312; cv=none; d=google.com; s=arc-20160816; b=U7W3jZogV8mFxI7I6J7AHvGypHmpeznv1Gcp0FZIHuJofwXJv2KyqmKXF8CAuLAN5s q+4g8Nwt1038jEZSa/H0qn7KiqEPC46ZWbUiqJjlqRUYCGvfgb4ISS8avWoNwvc9cZFd O7JrlsZ+F+UOZfUpRjPDhkvVyh+De+azC3BrYt0LWOzKRmTgLnCcnJUZYnU/HDUrFRSp QI8qr8Aa/N3UoNhE/sKS0+tikLbrwkrmU3PX2I5ST59IR9P9N7J7ybTsoUQuMfQ07uN/ HVNmP6RUnVL6PBbmKu9wC/8q831rhF6/WElNbGSpALo8KaZKlkf6hndhcZyrIMMsgnIW ziKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=hJBvE0A2W0OTlrwgVJMiJqMH1jsisTtDfheWFrFevdk=; b=iGvhQ++IuVFZWUCnZrabyGGtAYV6eY8X3g/OMuC9LuTxrRs2XvFoemvDQ3Y6gaRqRc ZzYnJvro/e+13HBTzYL3NAl27CQrgUOix8xzY/+wTI6ttBa3plopru1PwKzu+jFAiaVv tNebFiXNxlS4kkyxcvlRq+nINWZFYvCj7sQUcra4HEGkIvjK2ZukXAmxhttbqT21R7BC BQ5FXfC0FqPlsCePMtsCMqV3ULnlodZVmJauspbAGVSgPNAM5QwCVT9Fig6ZPhZy3j8n y+Gi8MY2VHym6O+O4vaZSaWB/QC5Guc3I8jbAvP796Gl+3mbEoAdLX2DljE+MLeDjU/C LnNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Mk8oxXVj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id re18si8584188ejb.684.2020.09.21.10.44.49; Mon, 21 Sep 2020 10:45:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Mk8oxXVj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727711AbgIURl0 (ORCPT + 99 others); Mon, 21 Sep 2020 13:41:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbgIURl0 (ORCPT ); Mon, 21 Sep 2020 13:41:26 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEF78C061755 for ; Mon, 21 Sep 2020 10:41:25 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id k15so13686697wrn.10 for ; Mon, 21 Sep 2020 10:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hJBvE0A2W0OTlrwgVJMiJqMH1jsisTtDfheWFrFevdk=; b=Mk8oxXVjBWstfqcdMc09xnyHcvLWcVVP6apT0fZ1+4yYrhwoKhwzDa9YQjAGUQg6wc gzD2MJVvLIha2BK135+vhf61x4eXDPgmlYx814XNs4ISswVtaLiL725EYR+VvpzYU1A+ D3IVBlwl6Ls7SwY1YGf/sb/guZ9JUOFpcVzjt9n8mQIjdqy1olRgJ8K2oiqb4Fx801Py /Us/GNHGpXw0iJZifaWZT7rLs5Xe91gVQeOAH0AfzbAvx1hmaI9ydMR5gCAvFqP2HfSn n7SSqNjhFRn6kBRwwJbyv33nlG3EEhavTKnT3cWTjmQQY0lHLzjT2fK137t6OMWdQamQ fbsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hJBvE0A2W0OTlrwgVJMiJqMH1jsisTtDfheWFrFevdk=; b=XOPWOKKhOFD6LQZmYEVtGM7lY7OADSoAwB6RoRMiFSjv7UgNWf8sR6KqByiK+cyJpN NoSCrIZBxJQJnnvo9ovRxV+BjbBvxFbBbGFi5hUTOlPQep0slPmW5H1aN+RI4A+X+2xA OBXyrXRZet1wG9eedDztlK9m8CsW0KNb4vHtH89rMsBsP0yFpThtekZiJoNV3KB5Vh05 NCXsR9ykyMHOwViXN147L7rR5iEQAGyRXIPPyXqgv90WukutCyByts8izdYeIPHD1os8 fY1CAZel8Objcg2n7CysupRZpCqBrzYZlZwRf54Juivf4h9sIxHXYIHUZfztdYB5kUEt 3Wlg== X-Gm-Message-State: AOAM533Hzwevb+k0jwtDz0gnMMcYX+t2wyomWXUqErBrbGdWpiZzVlx3 vkwK7/GAm2fxaRDKpmzF53adlchHpTLGyc48 X-Received: by 2002:adf:e289:: with SMTP id v9mr956308wri.14.1600710084399; Mon, 21 Sep 2020 10:41:24 -0700 (PDT) Received: from localhost.localdomain (cpc83661-brig20-2-0-cust443.3-3.cable.virginm.net. [82.28.105.188]) by smtp.gmail.com with ESMTPSA id b11sm21538674wrt.38.2020.09.21.10.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 10:41:23 -0700 (PDT) From: Alex Dewar X-Google-Original-From: Alex Dewar Cc: Alex Dewar , Mauro Carvalho Chehab , Greg Kroah-Hartman , Yu Chen , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: hikey9xx: Fix incorrect assignement Date: Mon, 21 Sep 2020 18:41:13 +0100 Message-Id: <20200921174113.19566-1-a.dewar@sussex.ac.uk> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its default value is assigned to priv->eye_diagram_param, rather than priv->tx_vboost_lvl. Fix this. Fixes: 8971a3b880b2 ("staging: hikey9xx: add USB physical layer for Kirin 3670") Addresses-Coverity: CID 1497107: Incorrect expression (COPY_PASTE_ERROR) Signed-off-by: Alex Dewar --- drivers/staging/hikey9xx/phy-hi3670-usb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c index 42dbc20a0b9a..4fc013911a78 100644 --- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c +++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c @@ -640,7 +640,7 @@ static int hi3670_phy_probe(struct platform_device *pdev) if (of_property_read_u32(dev->of_node, "hisilicon,tx-vboost-lvl", &priv->tx_vboost_lvl)) - priv->eye_diagram_param = KIRIN970_USB_DEFAULT_PHY_VBOOST; + priv->tx_vboost_lvl = KIRIN970_USB_DEFAULT_PHY_VBOOST; phy = devm_phy_create(dev, NULL, &hi3670_phy_ops); if (IS_ERR(phy)) -- 2.28.0