Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3387486pxk; Mon, 21 Sep 2020 12:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUj6ngXvAkQBF/aejypdr+D0RBmiEPWAZUzmSLU5zSSJ2HEC942k49w0UE5xtfufyp72GD X-Received: by 2002:a50:bb62:: with SMTP id y89mr412643ede.261.1600715912874; Mon, 21 Sep 2020 12:18:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600715912; cv=none; d=google.com; s=arc-20160816; b=V2eSGcu4rSrlZt+ElbmqaP77ZC15HzF1ySGl+7Jfyhk1GvBbqNdYMYkJcY8vSkHoVX Vs9hv/oTTNlihABar0uzVXHxR88bMAqaLqGK2lG3nXMnlZ7fwB2AZ+4zusyI0Fy7FhC8 xx3pmyRrUxCR+v33MFrccqa2av+1a75SBAbGcpGbQxxj71rmbKmNHp6LzkygjVgPUB/6 WaC2vlpB78SVh2Z57EPPZ1XPK9CpiIDSNQSKmnpekd8zsF0LMmJHusxO6D90VpgRVMxT 8SbtqP/RFWD9MR7PXkL0F5tQbF4jvmNuXr/LKS09rwV9ARRgmk2kBcwIjgrrqPmtvAdA 214g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=6UK6pFGt9egleebc1ma/B/6425Pzzz2Y948T88H5mEs=; b=Set28JcCQ+0VDvmfIw3ADtk9KreHtZZ8icabVjqZP9m5V2K5+rpS7FDIfGVmMgvFkC brAmWnNlMdbWgoD9pb2JqQ5EDSbMBZpsKR0xJE/mj/tPgXqd6bQHQGd4EtKgIka8g8LD m5g2Wgb8hhiF0ESFROqRvZYdgmtkXHUgWvGrZKAZw7RH3gKGb60hxwN2H8a2C0RG8pHm MpH+pDtLkCyuwZV/PuC5PncrM7weVbO5kX/QOSYfr/R5mEngg9iv9SlXrJDUcaFSwwUp NyWGMQ91kMx1jxdyszQh6NmdYEfbfWAIOB70DTWjqAage7aQImsOjRAr+nMdRPbZnpmZ 3jxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=ubUJwzRg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sa7si10075147ejb.714.2020.09.21.12.18.09; Mon, 21 Sep 2020 12:18:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=ubUJwzRg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728051AbgIUTQd (ORCPT + 99 others); Mon, 21 Sep 2020 15:16:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727836AbgIUTQa (ORCPT ); Mon, 21 Sep 2020 15:16:30 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60FBBC0613CF for ; Mon, 21 Sep 2020 12:16:30 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id f142so16348178qke.13 for ; Mon, 21 Sep 2020 12:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6UK6pFGt9egleebc1ma/B/6425Pzzz2Y948T88H5mEs=; b=ubUJwzRgnJoOGCxpuXvFu5hwLnlqkI78ayNPsbzfbWH2n4SrinrgDcdZIjJ5qVsNp2 TLWawpYZ9ZzxPdE+pa00LqbUbf4afC790T6KOo7H9rqyihjhC0ODnxiAudiZIi4ZrnQ4 niI8JOpbk/ZC00TsyaT/Ahq8YasUpvrMrV+5diB+AYypjO7zgov0zLd5WntjVPa8eLs+ r0Gc07YcfkWZ/t+TKv2NqlftUjEVELmUOdZF/CDExAItHi+Xc/Ju35QwJzYcs7N686zx qRvOyYtoTTuQVrOPC02qtSc8Z/I5ZHsx83oCzIoM1sGPIuus+NT7/gZimERHnGG5rpp7 j/Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6UK6pFGt9egleebc1ma/B/6425Pzzz2Y948T88H5mEs=; b=iYAyVvXw1uzxzfLY+ErBXEUfe8ZXZjDCV2r5J4EPC0MtqwopUmvP9tnpG9t3TgK2IM +W4B4PcqMRtlGn7uAuH0br9tbcIvX5kRZsQKhYWfCPNjf4ivbVHYfjJ8aqBwIsQt5jHZ lQffuwHwvl/MI6r+6w4nIZdhOrxlkGNgRyFDi2Nr+IMskTpcd0ys6MVDkE1oOmvS9PTb EIEFJe6Zzw0UouQ7N80ewlPPJ8i19U6nSf2TCsgz2OyGYR5dweIub0SRJvRXqBSL1F0s tIHz6tmdTpPV+D+35KJUcXnEoyf/yKhNwlN4K3GoReqT151nRYnVwIjPAhSrPh6d9lkd 8qFA== X-Gm-Message-State: AOAM533e9MYXS+/Cj8X3xgAyesFrsNB7GqcWUHFeMiATbcr0prrP7+Xa ApzMQEMB1bVkryEhtlszcYP+jefmdVSktvv3 X-Received: by 2002:ae9:de85:: with SMTP id s127mr1216977qkf.59.1600715789207; Mon, 21 Sep 2020 12:16:29 -0700 (PDT) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id y7sm10748586qtn.11.2020.09.21.12.16.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2020 12:16:28 -0700 (PDT) Subject: Re: [PATCH] btrfs: Fix potential null pointer deref To: Alex Dewar Cc: Alex Dewar , Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200921191243.27833-1-a.dewar@sussex.ac.uk> From: Josef Bacik Message-ID: Date: Mon, 21 Sep 2020 15:16:27 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200921191243.27833-1-a.dewar@sussex.ac.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/21/20 3:12 PM, Alex Dewar wrote: > In btrfs_destroy_inode(), the variable root may be NULL, but the check > for this takes place after its value has already been dereferenced to > access its fs_info member. Move the dereference operation to later in > the function. > > Fixes: a6dbd429d8dd ("Btrfs: fix panic when trying to destroy a newly allocated") > Addresses-Coverity: CID 1497103: Null pointer dereferences (REVERSE_INULL) > Signed-off-by: Alex Dewar Reviewed-by: Josef Bacik Thanks, Josef