Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932366AbWHCHX5 (ORCPT ); Thu, 3 Aug 2006 03:23:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932368AbWHCHX5 (ORCPT ); Thu, 3 Aug 2006 03:23:57 -0400 Received: from mtagate3.uk.ibm.com ([195.212.29.136]:43959 "EHLO mtagate3.uk.ibm.com") by vger.kernel.org with ESMTP id S932366AbWHCHX4 (ORCPT ); Thu, 3 Aug 2006 03:23:56 -0400 Date: Thu, 3 Aug 2006 10:23:52 +0300 From: Muli Ben-Yehuda To: Rolf Eike Beer Cc: Andrew Morton , linux-kernel@vger.kernel.org, Andi Kleen , discuss@x86-64.org Subject: Re: [PATCH] Move valid_dma_direction() from x86_64 to generic code Message-ID: <20060803072352.GE4736@rhun.haifa.ibm.com> References: <200607280928.54306.eike-kernel@sf-tec.de> <200608021720.40815.eike-kernel@sf-tec.de> <20060802185527.GB4982@rhun.ibm.com> <200608030825.19651.eike-kernel@sf-tec.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608030825.19651.eike-kernel@sf-tec.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 26 On Thu, Aug 03, 2006 at 08:25:19AM +0200, Rolf Eike Beer wrote: > > ./arch/x86_64/kernel/pci-swiotlb.c:6:#include > > ./drivers/net/fec_8xx/fec_main.c:40:#include > > ./drivers/net/fs_enet/fs_enet.h:11:#include > > ./include/asm-x86_64/swiotlb.h:5:#include > > I suspect it to be a bug anyway that every of this files ever included > asm/dma-mapping.h. Agreed wrt the fs_enet and fec_8xx; the swiotlb stuff I dimly recall I had a reason for. I'll take a look in bit to verify akpm's fix works. > > ./include/linux/dma-mapping.h:27:#include > > This is perfectly valid, isn't it :) :-) Cheers, Muli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/