Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3460921pxk; Mon, 21 Sep 2020 14:28:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzPpz+3k1CiVToynhED3x4mEB1xLAK7AenSNW5ZLv6zI1lLV+BiUr9sTWLmYCEfqloCgJ9 X-Received: by 2002:a17:906:28c4:: with SMTP id p4mr1462321ejd.345.1600723694318; Mon, 21 Sep 2020 14:28:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600723694; cv=none; d=google.com; s=arc-20160816; b=Kb+tJFmDhbRPjjZpn3L7ka5KQWwEgxKkrdO9vQnPOuktmoXj5Nqluabtn4E7waU6YS QBwaS7+03NICo+7bevYkOAIBJpFBbQpadfoShDAxQWyON4KiMrWhTaZoSpftT/FCVyL6 ZPgYqNGOqcc2sUCCgooDAHRGYQE4e5cJ609HOf6x4BiCula4Y4P4LmLWv6IPIQnGrQz7 2ldbyrii6RTh32CLt62NZQ7UpPJDAyfcNsW6KV093+FOV6o0JqCj7qsQdUJxGVzAWhZQ EP1SLqssDlPbkMIud6krZV9lpbpiZazJMTgn5Lk3we6o7bArI/T1TBsxs0M+NHPP9zeE ZI7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=0iHraPDG1dqCgKRjtQMUSU77zGp3yTSMUKvYTJoqBco=; b=HUc772I5xItqF1FcevP26EFx3ijynMdGxSyKpTsW2Z0xZXve877Ig4HsvLt4ZAD+A6 hdG7j+8JTFGQ54959pWSbNgm93ZQ4L3+mXJBK7y9IkNjwDkSdwGlgn5/1tqLfuqYir9A c2qnzrxzXVUxo9jvSu/Lhvf5INSNT9jQBZ/+f29523KMgxOA1TBu1gQNyhIqwi5LJKeL 7HOkggCQuamCKdDk55k5whIO+lfRwvfHRK0K3VSFhkGZRQ+suETogeBXnbNG8u5h5uCw 98mq+9RbBHfeGw3wEv/be76AWrXyye3EIi2CX+uZeY1KhLXIzKhdGWzwLZ39pNmvsYlJ VE7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z23si9103473edx.215.2020.09.21.14.27.50; Mon, 21 Sep 2020 14:28:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727793AbgIUV0s (ORCPT + 99 others); Mon, 21 Sep 2020 17:26:48 -0400 Received: from mga18.intel.com ([134.134.136.126]:27497 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbgIUV0r (ORCPT ); Mon, 21 Sep 2020 17:26:47 -0400 IronPort-SDR: td84sAxeDzTxHcb/38PT2hEV4d94fiOp5+NT3mLkqFn8kiFzwddddwNN+bJdy8t0RnK9td0haI IX/Lt0fCT8WA== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="148236530" X-IronPort-AV: E=Sophos;i="5.77,288,1596524400"; d="scan'208";a="148236530" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 14:26:46 -0700 IronPort-SDR: 8hTzxnHAWYHcALgtM6rYikOTI+yHRcM5M8fwXePA/kS0QmDiDwK/qbnrk83Lzd2gwyKPbLEKdp VkZTjrJzvgXQ== X-IronPort-AV: E=Sophos;i="5.77,288,1596524400"; d="scan'208";a="485671677" Received: from kofels-mobl.ger.corp.intel.com (HELO localhost) ([10.249.45.179]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 14:26:40 -0700 Date: Tue, 22 Sep 2020 00:26:38 +0300 From: Jarkko Sakkinen To: Borislav Petkov Cc: x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Jethro Beekman , Darren Kenny , Andy Lutomirski , akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, asapek@google.com, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, sean.j.christopherson@intel.com, tglx@linutronix.de, yaozhangx@google.com Subject: Re: [PATCH v38 15/24] x86/sgx: Enable provisioning for remote attestation Message-ID: <20200921212638.GB59547@linux.intel.com> References: <20200915112842.897265-1-jarkko.sakkinen@linux.intel.com> <20200915112842.897265-16-jarkko.sakkinen@linux.intel.com> <20200921180728.GJ5901@zn.tnic> <20200921192706.GD53597@linux.intel.com> <20200921194156.GM5901@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921194156.GM5901@zn.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 09:41:56PM +0200, Borislav Petkov wrote: > On Mon, Sep 21, 2020 at 10:27:06PM +0300, Jarkko Sakkinen wrote: > > 'sgx_dev_enclave' is successfully register whenever that happens. Am I > > missing something here? > > No, I was missing the fact that you have *two* misc devices and you're > deregistering the first one in the error path of the second. > > Forget what I said. ;-\ Ok, great. BTW, probably would make sense to rewrite the short summary as: "x86/sgx: Add SGX_IOC_ENCLAVE_PROVISION" for the sake of consistency with the three precursoring patches. > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette /Jarkko