Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3473566pxk;
        Mon, 21 Sep 2020 14:53:44 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxeIvVMhWk5pAHDZyG2Ft/kisFbWy1pKlDVtlJxWzvhB+r12thsp21BXmMBR7kg+AQzxZuF
X-Received: by 2002:a05:6402:1851:: with SMTP id v17mr992512edy.46.1600725224202;
        Mon, 21 Sep 2020 14:53:44 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600725224; cv=none;
        d=google.com; s=arc-20160816;
        b=DgK0RLtjjmmeY9mNoU8l+biUOfGyM6RmzhSYfFcEpJwg7WvJEXl8rIT83uc7zeVHUo
         d/eZT3/tcmbxGvpXXY6Af7gkxI8Dx7UxEIc1loi2KM6bgMUsWyg+oExEgMZxKP02ubxu
         UFOGKLWCySGXuyiB1i9leiIe0C3vBPzL55ewEdD//MecVIz69mYaA+iaP6AsWwXXSHr8
         t6y0ElNk0weVR7sqI06Z7JvjpHZdpGRbgsX+O1Z+4/wNvT7pO/nTDwIJAcQddG0J9eeh
         ZaQ+nJ8+wtXWGQV97qna6tGUwOyEKLxGRmyzq96Wj9vC3QC4PrP4W7H+l7HeqAJ91aNP
         gIFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=0W1Egwj2eO/oYGTia8BNbka0b4xhhWXu/wV+z8LiKdo=;
        b=Ztq6vIcgBGWs9iN3lrdk71v0ugofa35CUFZdQ6Gvkj0ZAxXt3AR/8UNGZj9jLhi7GA
         T5HOQ2nDNPxHiphauFFxs/0r9E0ZhzHe8rnuORpjDcZA+o99CSXESqUTI3jxmaTC82Bp
         A+xLGnaHMq7UV09XNGdlsj4slTEKINymW9PFLxqo44RqUD09uUvkyjKUbi5Yy7fWAJ4H
         V5LpEtkfX9J0ofVR9XXRwxJc44w0b9kmetsi9NF8Cxb5Uz5eYvn9i7LgPZXd7jf1DEdB
         P325mgBjpk089QtxjgOQegkh4OHS8FHlCw+eV1t7sm7Gr99Z62L026cuBb6uU9+2Gxmt
         HUew==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id n10si9607011ejk.73.2020.09.21.14.53.21;
        Mon, 21 Sep 2020 14:53:44 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727639AbgIUVwC (ORCPT <rfc822;yxhlfx@gmail.com> + 99 others);
        Mon, 21 Sep 2020 17:52:02 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53352 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726452AbgIUVwC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Sep 2020 17:52:02 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5543C061755;
        Mon, 21 Sep 2020 14:52:01 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 9F92811E49F62;
        Mon, 21 Sep 2020 14:35:13 -0700 (PDT)
Date:   Mon, 21 Sep 2020 14:52:00 -0700 (PDT)
Message-Id: <20200921.145200.2255128901470643620.davem@davemloft.net>
To:     jingxiangfeng@huawei.com
Cc:     kuba@kernel.org, ktkhai@virtuozzo.com, pabeni@redhat.com,
        tklauser@distanz.ch, steffen.klassert@secunet.com, cai@lca.pw,
        pankaj.laxminarayan.bharadiya@intel.com, arnd@arndb.de,
        vcaputo@pengaru.com, edumazet@google.com, sd@queasysnail.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: unix: remove redundant assignment to variable
 'err'
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200921032952.99894-1-jingxiangfeng@huawei.com>
References: <20200921032952.99894-1-jingxiangfeng@huawei.com>
X-Mailer: Mew version 6.8 on Emacs 27.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Mon, 21 Sep 2020 14:35:14 -0700 (PDT)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jing Xiangfeng <jingxiangfeng@huawei.com>
Date: Mon, 21 Sep 2020 11:29:52 +0800

> After commit 37ab4fa7844a ("net: unix: allow bind to fail on mutex lock"),
> the assignment to err is redundant. So remove it.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
 ...
> @@ -878,7 +878,6 @@ static int unix_autobind(struct socket *sock)
>  	if (err)
>  		return err;
>  
> -	err = 0;
>  	if (u->addr)
>  		goto out;

Yes, err is always zero here in this code path.

Applied, thanks.