Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3666223pxk; Mon, 21 Sep 2020 22:15:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7s+OBW+H45SZ26bBks4VH2voQukNnQFQbKfbZmcW10n0CdNNXIbtL3pEqjP80KQhE8TVG X-Received: by 2002:a50:8e52:: with SMTP id 18mr2275295edx.28.1600751730842; Mon, 21 Sep 2020 22:15:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600751730; cv=none; d=google.com; s=arc-20160816; b=KXV62ns2Ooac2NWCvjvfVA4LreUmAwlmp/eAMWBcyI7sEpwqL5frfAhYW5TrMeVtH8 iCzQgMInbSNo0CGsABcEB8CcGfHAYsAsMWSjjuGMweuYiiolbGZCKPyKDJBjDjyHkS7d 69foOUIn/pmnjKdMHKj05qmjr8wBKXQRKC47DTp3n0f2ruoFCbtdu5ruo50Rdad1UPyc Z0RlRnkBPCIAZ4lDmE+z8P8yr9/aiVxhBGjK8VmeKDeG/rcM5J29qfA1oTztBTiLYtxI kTioy3c7gX5ECaozEfe1D4oEjrPpqNqtcYH9Cy33PWEFTIwH/yVSFkRnUWpfRuKuisQK E9vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=VJWqlPK0QksOxpXEHfdlaBDYGflHsTgwkc11M4Pq2Xw=; b=x5LQf8yJF6PVq2/MifN0qk3HFD7sF6zEzFPcm1qkzEvR4Gob59JGJHMx3/m+bMMVrz 6o7E467kk69FPJ87/ngSd/zMrkNi/FjzjLD46yD9Pd0H0vSCqQ/95B8VyGUsBO5jzdOY pc3ic6chec/wT+2c456aMW+KfBs2M/siXJdSCaF5wt2tsjG1vsvHFJSqymA23i4+PtMM +aXA4XSx/zQcsXj42Tn8h82DwmL2xObYs1nXq3+5ou73y41CgZJ8dFSY4xaS0Oltx+lZ Zm4wN0UTUgKrQt0JEsNdCnDDnTbn/+ifbQv2Dg6A5qhrUROJwqv/vD7vyQDqfg1KjEfP Z7ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si9383547ejz.637.2020.09.21.22.15.07; Mon, 21 Sep 2020 22:15:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727407AbgIVDke (ORCPT + 99 others); Mon, 21 Sep 2020 23:40:34 -0400 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:60877 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgIVDke (ORCPT ); Mon, 21 Sep 2020 23:40:34 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0U9jwaHs_1600746028; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U9jwaHs_1600746028) by smtp.aliyun-inc.com(127.0.0.1); Tue, 22 Sep 2020 11:40:31 +0800 Subject: Re: [PATCH v18 15/32] mm/lru: move lock into lru_note_cost To: Hugh Dickins Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com References: <1598273705-69124-1-git-send-email-alex.shi@linux.alibaba.com> <1598273705-69124-16-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: Date: Tue, 22 Sep 2020 11:38:22 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2020/9/22 ????5:36, Hugh Dickins ะด??: > >> We have to move lru_lock into lru_note_cost, since it cycle up on memcg >> tree, for future per lruvec lru_lock replace. It's a bit ugly and may >> cost a bit more locking, but benefit from multiple memcg locking could >> cover the lost. >> >> Signed-off-by: Alex Shi > Acked-by: Hugh Dickins Thanks!