Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932452AbWHCJnM (ORCPT ); Thu, 3 Aug 2006 05:43:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932450AbWHCJnM (ORCPT ); Thu, 3 Aug 2006 05:43:12 -0400 Received: from pfx2.jmh.fr ([194.153.89.55]:54161 "EHLO pfx2.jmh.fr") by vger.kernel.org with ESMTP id S932445AbWHCJnL (ORCPT ); Thu, 3 Aug 2006 05:43:11 -0400 From: Eric Dumazet To: Evgeniy Polyakov Subject: Re: [take3 4/4] kevent: poll/select() notifications. Timer notifications. Date: Thu, 3 Aug 2006 11:43:02 +0200 User-Agent: KMail/1.9.1 Cc: lkml , David Miller , Ulrich Drepper , netdev , Zach Brown References: <11545983601@2ka.mipt.ru> In-Reply-To: <11545983601@2ka.mipt.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608031143.03064.dada1@cosmosbay.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 28 On Thursday 03 August 2006 11:46, Evgeniy Polyakov wrote: > poll/select() notifications. Timer notifications. > > +++ b/kernel/kevent/kevent_poll.c > +static int kevent_poll_wait_callback(wait_queue_t *wait, > + unsigned mode, int sync, void *key) > +{ > + struct kevent_poll_wait_container *cont = > + container_of(wait, struct kevent_poll_wait_container, wait); > + struct kevent *k = cont->k; > + struct file *file = k->st->origin; > + unsigned long flags; > + u32 revents, event; > + > + revents = file->f_op->poll(file, NULL); > + spin_lock_irqsave(&k->ulock, flags); > + event = k->event.event; > + spin_unlock_irqrestore(&k->ulock, flags); Not sure why you take a spinlock just to read a u32 Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/