Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200921190433.1149521-1-jim.cromie@gmail.com>
 <20200921190433.1149521-2-jim.cromie@gmail.com> <88110ffe6b08a2b403f30f4ea7463d5dad50b80b.camel@perches.com>
In-Reply-To: <88110ffe6b08a2b403f30f4ea7463d5dad50b80b.camel@perches.com>
From:   jim.cromie@gmail.com
Date:   Mon, 21 Sep 2020 21:57:22 -0600
Message-ID: <CAJfuBxz1Qt6xXky7hT2NM6G0XRQ5SEQii7ydNJRMFZmV15o4Yw@mail.gmail.com>
Subject: Re: [PATCH 1/2] dyndbg: dont panic over bad input
To:     Joe Perches <joe@perches.com>
Cc:     Jason Baron <jbaron@akamai.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Petr Mladek <pmladek@suse.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 21, 2020 at 1:29 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2020-09-21 at 13:04 -0600, Jim Cromie wrote:
> > This BUG_ON, from 2009, caught the impossible case of a word-char both
> > starting and ending a string (loosely speaking).  A bad (reverted)
> > patch finally hit this case, but even "impossibly bad input" is no
> > reason to panic the kernel.  Instead pr_err and return -EINVAL.
> []
> > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> []
> > @@ -259,7 +259,10 @@ static int ddebug_tokenize(char *buf, char *words[=
], int maxwords)
> >               } else {
> >                       for (end =3D buf; *end && !isspace(*end); end++)
> >                               ;
> > -                     BUG_ON(end =3D=3D buf);
> > +                     if (end =3D=3D buf) {
> > +                             pr_err("expected non-empty bareword");
>
> missing newline
>
> This message is also unintelligible.
> What is a non-empty bareword?
>
>

hmm, I borrowed the term from perl

en.wiktionary.org =E2=80=BA wiki =E2=80=BA bareword
(programming, chiefly Perl) A sequence of text characters in source
code that do not form a keyword nor part of a quoted string, and may
potentially be interpreted ...

basically, a not-quoted word, a keyword or not-quoted-value

Im open that there might be better terminology.
have any suggestions ?