Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3766965pxk; Tue, 22 Sep 2020 01:50:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxh/iFxxmg1ivq+3i63hT/RyIAcInN1JHygo9TNXagKkCHg+Y7oVBb2ZVPZefu/rZ7gAEzW X-Received: by 2002:a17:906:e88:: with SMTP id p8mr4003246ejf.134.1600764620822; Tue, 22 Sep 2020 01:50:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600764620; cv=none; d=google.com; s=arc-20160816; b=Uc9VWNsOe4ISlWBOC/L2mcbewAjnO1DsoSnqr9R920SoVc3r1tIIk/+VDhJiZn4d09 Fp5Hb1OvY9cMwzQx1ScstH9s9XroXSXYdNySRjzBoJ3kECJL5UTU0GYiQGYCoEwZXTBs kv0Ua5reEsGCFzu4qERX/YJc9nc+ZoChY3RdTVTo2us5tOJoJus80jQetiIFq227Ky1G XZrW/wlSxDTzlG8F6+rKBAUenzumQUexoP/5+x8/2X1b35YlxDZr7xHVK147WtmEAChf QJq8+BYsvVexd4KlB2N93rLaUYv2DIO6VL5uu3iPJAzjDdzQdxaBVPdxi6tiKstIRnXT 99SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=TSLXVtoTI8WcynfZCM9p8qAScLdtudW+zl6SsyXq4Fk=; b=twHQGWUxqVGrc5a9nv6qPj586yXJsVkIM06WIsALqID3WK1dr4lOFxw/aoUYSiLdcV 5jh2nJn2g1FH8Z6sC/p7ZpzipVcY0jAwDdVs6DLPqzqbJM+lCtZbaAprI91X414bSWke aN8YWUvxESRzlxEHIC3Y/uAu6+ODelpkWY/9lPz14f9XhrzwhDRwchvFJG757rIoIwhQ pCLoqAEnoZ2H3sE15jDjT3hQFT4ymshEXThTTzmKxTt4SkvbZ+kJyGY7UKbU+sX/UFQz VE2ulnYL2oW1meirSLiBqRDFzJgLUxpCTYt/ZrF007QtG/6QF7n1G5tWCmpueMFe+hS3 z1CQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id wn10si10068402ejb.19.2020.09.22.01.49.56; Tue, 22 Sep 2020 01:50:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726461AbgIVIs5 (ORCPT + 99 others); Tue, 22 Sep 2020 04:48:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbgIVIs4 (ORCPT ); Tue, 22 Sep 2020 04:48:56 -0400 Received: from hillosipuli.retiisi.org.uk (hillosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::81:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D85C061755; Tue, 22 Sep 2020 01:48:56 -0700 (PDT) Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 03C27634C87; Tue, 22 Sep 2020 11:47:46 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1kKdxj-0002fR-3R; Tue, 22 Sep 2020 11:47:47 +0300 Date: Tue, 22 Sep 2020 11:47:47 +0300 From: Sakari Ailus To: Luca Ceresoli Cc: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, hverkuil@xs4all.nl, jacopo+renesas@jmondi.org, leonl@leopardimaging.com, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/3] media: i2c: imx274: Remove stop stream i2c writes during remove Message-ID: <20200922084746.GA8644@valkosipuli.retiisi.org.uk> References: <1600724379-7324-1-git-send-email-skomatineni@nvidia.com> <1600724379-7324-3-git-send-email-skomatineni@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luca, On Tue, Sep 22, 2020 at 10:09:33AM +0200, Luca Ceresoli wrote: > Hi, > > On 21/09/20 23:39, Sowjanya Komatineni wrote: > > Sensor should already be in standby during remove and there is no > > need to configure sensor registers for stream stop. > > I beg your pardon for the newbie question: does the V4L2 framework > guarantee that the stream is stopped (.s_stream(..., 0)) before removing > the driver? It doesn't. That's however one of the lesser concerns, and I don't think it'd help if drivers tried to prepare for that. -- Sakari Ailus