Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3802828pxk; Tue, 22 Sep 2020 03:03:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7/dVgJyXy2wKrQxdiW9sin8DB3zjxRTECPewDYtHMoLxTzr46sZrz8y2ryIsaGa5ud50C X-Received: by 2002:a17:906:95d1:: with SMTP id n17mr4200780ejy.324.1600769013746; Tue, 22 Sep 2020 03:03:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600769013; cv=none; d=google.com; s=arc-20160816; b=knOiGQ3NI94KmAkmglyEq3lXYdl2w6DYrBfANvXD4gzp49gt26omy7qgaD/IIr62+v qcly/RaJLWI4YMcRTas9rtDqFnlWeerrH2A3tExlR/+bf3ekRbLkQXz1Y5q9aipQpNYw kVMXLsusSOsak6S3tyj9lqGybLft9UxHQey8Xvb7DpxPpEO80wUl7l0XxeBP8WLNsK3v y7h8t2bCb0az6nWgQIUuwP2jKttdwvJOWpQ4hR0tnHkcPPOZr971uGvbsPkQfgSStmAT A39K6fAcBHrh1ZU4zmR7ufShvw36eq8/G2SMaVqNGOBYYzx/WZqH9EIMJRR6YmC2VyGp baRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QLO3suN0B5LIt4PxRcxRdNDdQcD9omAqbXVobcJQit0=; b=m7d4sdw83U5Dl7cEt0K7CzW0qQ6DSHz5jGNqGr3yJxza7xCPzfkAHPOCSI5k2Jy8en NmZobUUupbTsmUVMaCHjzTcMCYP7AC0sHUSjpsqHShh/H7+e4X/rMRECyAXLD+2HlW0K 0VVvsLaLh1KZQJ3CLHcbRFesNYN++P4BdM1xB93CjlWdVxWQv3DXmWJSjvdo0PzAxfIy hEC7XkC3jpf/st9GI4OusyvJgbeYEIH0WG6brbwj16Qzbf0D3bJ+v2CztyRf4dgSWtZO Md0w+jfW7HMqIFMygFyPtuiUFDVK+s8iU5KhhprsXM/rYCsgeeYl4dFC7jbTrQGFNLvS W6MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=bvB8VbMc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr18si10058578ejb.45.2020.09.22.03.03.09; Tue, 22 Sep 2020 03:03:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=bvB8VbMc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726576AbgIVKB4 (ORCPT + 99 others); Tue, 22 Sep 2020 06:01:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:37456 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgIVKBz (ORCPT ); Tue, 22 Sep 2020 06:01:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1600768914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QLO3suN0B5LIt4PxRcxRdNDdQcD9omAqbXVobcJQit0=; b=bvB8VbMcv76lg7v+mTn3uy5QgST4NRQnUu47qUNl8D+fm1OVsZ7ir5iOajEgMTc5mRolsx +JdjG1UKUAcMkTR1JPArn3y+yQ4W+XuUYFTGDk2Xl/4Whb68KND0i+avmivAL2Jgd2GPke OFEuWW6aD69MpOK/i3dMkpRkCKNKoZU= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9B66B1AD; Tue, 22 Sep 2020 10:02:30 +0000 (UTC) Date: Tue, 22 Sep 2020 12:01:52 +0200 From: Michal Hocko To: Yafang Shao Cc: zangchunxin@bytedance.com, Johannes Weiner , Vladimir Davydov , Andrew Morton , Tejun Heo , lizefan@huawei.com, Jonathan Corbet , Alexei Starovoitov , Daniel Borkmann , kafai@fb.com, Song Liu , Yonghong Song , andriin@fb.com, john.fastabend@gmail.com, kpsingh@chromium.org, Cgroups , linux-doc@vger.kernel.org, Linux MM , LKML , netdev , bpf@vger.kernel.org Subject: Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2 Message-ID: <20200922100152.GW12990@dhcp22.suse.cz> References: <20200921080255.15505-1-zangchunxin@bytedance.com> <20200921081200.GE12990@dhcp22.suse.cz> <20200921110505.GH12990@dhcp22.suse.cz> <20200921113646.GJ12990@dhcp22.suse.cz> <20200922072733.GT12990@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 22-09-20 16:06:31, Yafang Shao wrote: > On Tue, Sep 22, 2020 at 3:27 PM Michal Hocko wrote: [...] > > What is the latency triggered by the memory reclaim? It should be mostly > > a clean page cache right as drop_caches only drops clean pages. Or is > > this more about [id]cache? Do you have any profiles where is the time > > spent? > > > > Yes, we have analyzed the issues in the direct reclaim, but that is > not the point. Are those fixed? > The point is that each case may take us several days to analyze, while > the user can't wait, so they will use drop_caches to workaround it > until we find the solution. As I've said there are several options to achieve an immediate action. Careful resource domains configuration will certainly help with that. -- Michal Hocko SUSE Labs