Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Sep 2020 13:04:17 +0300
From:   Vadym Kochan <vadym.kochan@plvision.eu>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 0/3] nvmem: add ONIE NVMEM cells provider
Message-ID: <20200922100417.GA22590@plvision.eu>
References: <20200915124116.7196-1-vadym.kochan@plvision.eu>
 <20200921235641.GI31031@plvision.eu>
 <f7f47794-2641-514a-8905-3f4c800f199d@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f7f47794-2641-514a-8905-3f4c800f199d@linaro.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from plvision.eu (217.20.186.93) by AM7PR03CA0003.eurprd03.prod.outlook.com (2603:10a6:20b:130::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11 via Frontend Transport; Tue, 22 Sep 2020 10:04:22 +0000
X-Originating-IP: [217.20.186.93]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 03107ca1-ec8f-4054-720c-08d85edee191
X-MS-TrafficTypeDiagnostic: HE1P190MB0330:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <HE1P190MB0330F0C824BE2CA8A8382724953B0@HE1P190MB0330.EURP190.PROD.OUTLOOK.COM>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: pDragZo8HI9NQn1plQtJMzQ8J5IHFAOzr7I5CymCZqOZWRo3F0BCpUNvqCL0Lar3V4NfNO6nfME2J4dbVVFX9QYjTpbIu7XYrX1pdryn0AI/H26z3X6IVl+yqQ9eB3+puAmRqTbDRn7jvDu7s6XXEwhh5DAajYgwyVs5s/WSqck6V9Uod9/c8lGZYWOsbe1qTrxsWlcQ9pj9yBU3FFFrbmI13JMUOOq0G1+kDHxRGPqJo/9/35xp4yt+kH/fU4N2N9PeEOsVU4RgXYYLJcNCiYX4k/ayUdzNP9Zle6uPp+1w0AefdxbdjuXGjvSn2q6E
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39830400003)(366004)(396003)(346002)(376002)(136003)(478600001)(66946007)(52116002)(2906002)(8676002)(86362001)(5660300002)(2616005)(956004)(36756003)(4326008)(1076003)(66476007)(66556008)(6666004)(44832011)(55016002)(316002)(8936002)(8886007)(6916009)(7696005)(53546011)(26005)(186003)(16526019)(33656002)(83380400001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: sSPeVgXqV0P6L2mZZ2u2M0vkK2xWNMZAMsZ9grcWJGKcVinDRZnI7jTu6nYxJhYU4DAG5Zbdt/T39blNPKkLwn0FnC57Ho6B1egT+Kgy2FubYFUXTb9D/dPE3h9t3obMvhvZr9lVa55bP1hh/V1n0JvyMPwwzZ8tulf0NumQGvt2H3mj8K8h9/GtY3F8mCMT9kHEc8KCrFkiqJob3/LyN+QHqUJ7jlTDam7gWTruzQNNvJ1K3goBmLihCa05eH1b29aGmi1xNgwxuH+/zOlIsFrzePenmU4F6BSEn3kwoJyCgDKXQZyLDMlhfVt3Swhxbmk2VMkXrfbihmN9XdpRfd6AtRhTOi5luA/s4WjbGlQGx9D7zd2+pld0+z6Hu4IzmvtQU7AdJ1hqtqhxIkfvlqwl8vHiYSaop7SWR4X0oZi8Q4CUP+regJCqpVLTDi5TgzJ/Ge2ZSEyfWp2RLbQt09kEV7kqIsV0l0yVew7YbBcQjlwfpyfkXfetoEHgwwvZafakaYBd9LT6FWstdj/rrhH1cu7gUyXL792PTViI3balTDhv8kTo0b/zfWfVa/knn2KHNXMkfGSZ6j8pGajVGxT6EQH7kyxXUajJ2qSd1tpPp2BzFq6fKfo5Wj1bJauOxY98nCAy/YHVmvpY0w9Nng==
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 03107ca1-ec8f-4054-720c-08d85edee191
X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 10:04:23.4220
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nQ/q+KbOfFc8CgXnjVSYxKzXOLmBOpjlP0NKNVMbh4YEhSioNpSwqhMO3t0s/EeCzIax2XTvrlhdlSMT9JAn4C4j4EmGdfPIiIFoM2N4gzo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0330
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Srinivas,

On Tue, Sep 22, 2020 at 10:48:23AM +0100, Srinivas Kandagatla wrote:
> 
> 
> On 22/09/2020 00:56, Vadym Kochan wrote:
> > Hi Srinivas,
> > 
> > On Tue, Sep 15, 2020 at 03:41:13PM +0300, Vadym Kochan wrote:
> > > This series adds cells parser for the ONIE TLV attributes which are
> > > stored on NVMEM device. It adds possibility to read the mac address (and
> > > other info) by other drivers.
> > > 
> > > Because ONIE stores info in TLV format it should be parsed first and
> > > then register the cells. Current NVMEM API allows to register cell
> > > table with known cell's offset which is not guaranteed in case of TLV.
> > > 
> > > To make it properly handled the NVMEM parser object is introduced. The
> > > parser needs to be registered before target NVMEM device is registered.
> > > During the registration of NVMEM device the parser is called to parse
> > > the device's cells and reister the cell table.
> > > 
> > > Vadym Kochan (3):
> > >    nvmem: core: introduce cells parser
> > >    nvmem: add ONIE nvmem cells parser
> > >    dt-bindings: nvmem: add description for ONIE cells parser
> > > 
> > >   .../bindings/nvmem/onie,nvmem-cells.txt       |  11 +
> > >   drivers/nvmem/Kconfig                         |   9 +
> > >   drivers/nvmem/Makefile                        |   3 +
> > >   drivers/nvmem/core.c                          |  80 ++++
> > >   drivers/nvmem/onie-cells.c                    | 370 ++++++++++++++++++
> > >   include/linux/nvmem-provider.h                |  30 ++
> > >   6 files changed, 503 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/nvmem/onie,nvmem-cells.txt
> > >   create mode 100644 drivers/nvmem/onie-cells.c
> > > 
> > > -- 
> > > 2.17.1
> > > 
> 
> Hi Vdaym,
> 
> Am totally confused with this patchset, There is no versioning in any of
> your patches, you always send it with PATCH, please add version so that I
> know which one should I review!
> 
> This makes my mailbox totally confused with all the patches with same
> subject prefix!
> 
> Please note that maintenance is not my full time job, so please be patient
> and I can try shift gears as an when possible!

Thank you!

> 
> > 
> > I sent a newer version than this one which actually registers nvmem provider
> > and does not require changes in the core.c
> This is a NO-NO as onie is not a real provider here, at24 is the actual
> nvmem provider in your case.
> 
> Why do you keep changing the total approach here! what is the reasoning to
> do so!

Well, I though that maybe anyway it also better to show the code, and
try different approaches.

> As I said in my last review we were okay with this parser approach!
> 
> I don't mind having changes in core as long as it done properly!
> 
> 
> thanks,
> srini

I am really sorry for this! I was really conceptually confused about how
to make it right by design. I will use "parser" word in next series
subject update with a versioning (v2) so you can identify that this is
related to parser approach with which you are conceptually fine.

Again sorry for this!

> 
> 
> 
> 
> > 
> > Thanks,
> > Vadym Kochan
> >