Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3832724pxk; Tue, 22 Sep 2020 03:57:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxk1lrUuW64bV1TSxUa2b4PYbCBsU4Xond7j1mC/qI2nlx7VRlOKGEEHqIdKqJUsgSf12SY X-Received: by 2002:aa7:d959:: with SMTP id l25mr3159689eds.383.1600772258995; Tue, 22 Sep 2020 03:57:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600772258; cv=none; d=google.com; s=arc-20160816; b=ZmkerBSm876AZmVQW38r0YtQy2Xf9gEmaItJs73xOZQ8rCKG8VPPNwZJZ6zQGLnHzR zqy84BOe6yQotFDlDUVOVL7naF93wQXY9Mulr1v9+PmQ1n6y5ASGF5+GfI5ovowYp2Tm 53cTyHHIfmKfFHska8LcCFFZZMz0wtDV0vs1HzukkisXdT175O6lrEIZL+zu1vGkVFUD 96g2XiWPT89ejK28jcy70m6E4D8I8gNmUSnEG8e6CAHZfM8VWFAQtjI3laFWSavxRYTU 0thFZIhFGTvRanJh7jsjYctIKZYd2s0lJ3OXIKqg0KHAbRO3dSzJ215lk8zVrlqs8O1i t6+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=j3obSL0AnNOT32akanjHZFOFiJbMf2SWFXiwQh7t3Kc=; b=vrteSizxxAOyyM+h6n/tPdAAz8p3rNKDY6kvZNtRnYy8zTUnTIZ7PNf/MZXbpNkyBU tX5dde4uTnhvKfC8QPTvyFeGyMmQZdHXpdEoZnDKF120x/ftnLB7rUegz2qzRLRA6nLR WqlYnoLbUHm29Ci5Qr1PbduAwGmK8VmHqLSPopo9I7mQPzmCtTHxspHAeoBi6dzdJDU1 80X76PBoOgFeRfquGHBbZ1w/BpxJ8Dhyncu3ul/LlBPotshzaycmVPpFQn3uHYpxA5Jo o7hRO3CuqMuwjtZOJEzhgC5w8B02HdU5KTHX7eEzfqpmuGVmwszB9orQrmaw/UEmTVzT YUHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u20si10342592ejz.602.2020.09.22.03.57.15; Tue, 22 Sep 2020 03:57:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbgIVK4U (ORCPT + 99 others); Tue, 22 Sep 2020 06:56:20 -0400 Received: from elvis.franken.de ([193.175.24.41]:51117 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbgIVK4U (ORCPT ); Tue, 22 Sep 2020 06:56:20 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kKfxr-000822-00; Tue, 22 Sep 2020 12:56:03 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id AF6B3C0FE6; Tue, 22 Sep 2020 10:48:48 +0200 (CEST) Date: Tue, 22 Sep 2020 10:48:48 +0200 From: Thomas Bogendoerfer To: Christoph Hellwig Cc: Mauro Carvalho Chehab , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Ben Skeggs , Marek Szyprowski , Tomasz Figa , Matt Porter , iommu@lists.linux-foundation.org, Stefan Richter , linux1394-devel@lists.sourceforge.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 06/18] lib82596: move DMA allocation into the callers of i82596_probe Message-ID: <20200922084848.GA8477@alpha.franken.de> References: <20200915155122.1768241-1-hch@lst.de> <20200915155122.1768241-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915155122.1768241-7-hch@lst.de> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 05:51:10PM +0200, Christoph Hellwig wrote: > This allows us to get rid of the LIB82596_DMA_ATTR defined and prepare > for untangling the coherent vs non-coherent DMA allocation API. > > Signed-off-by: Christoph Hellwig > --- > drivers/net/ethernet/i825xx/lasi_82596.c | 24 ++++++++++------ > drivers/net/ethernet/i825xx/lib82596.c | 36 ++++++++---------------- > drivers/net/ethernet/i825xx/sni_82596.c | 19 +++++++++---- > 3 files changed, 40 insertions(+), 39 deletions(-) Tested-by: Thomas Bogendoerfer (SNI part) -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]