Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3832920pxk; Tue, 22 Sep 2020 03:58:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGD8WWKR1VTDu/18Omjl/PEJQTi/4g3/CS5tbv10i/beL6MtFEUpusiWmgOB/7YjZBGsw4 X-Received: by 2002:aa7:cb8f:: with SMTP id r15mr3344964edt.356.1600772284785; Tue, 22 Sep 2020 03:58:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600772284; cv=none; d=google.com; s=arc-20160816; b=tqiuYNLAY2+vasyM80L6G3KV5NBM6g/loVjLgCsqn9eimPC3+O3xEWgHGwMRsz9QB3 DjSBYE9BXjich5cnPt9Pm0S2QPl05MKD0yn+qSqgaiUqP+SO/ujZmbjziaeWY5kMqEAb 1/sM0y0rOCP2yxFkUG5GHHWtriZsub37cq32HgFTqizv1luOJGntnVHPQLw+pukyjyre uuE9cvVlzUHFll7CW7NU1sKxJY4/FqWW5/PrMO8rV3LDkMRdDDAL/8DK9ysMNfDJTjlY IOBrLEkvol5Tmq3lI2D5elyn/69YuPNmuAJoRGfcJmdf3hyXU/4Zf85MbDNB3Z9zBMDK VkAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=HRAjFbl8kz0clQ9p9R5MI7cFW9aEHxJSZrge4zJfpFE=; b=BMtDns36wwEwp3eM4ozSOvqlT1yD9+mwYdVrPGgId372CigQ+XYxNwYMYlQw3DGUf7 pHkdelgVSzlPgMMjq227fQorm/2z5v0j+gpPeRViskckmhhOuIj1xgiRi4gT8nYFUvzx TU/ioHF9m265DImIJTKCdjYBFBJqv7F4BFzr9Tlb6bOPq33WCPTWzm1zcx72j6ouVHFm ZQTKluIvsO9pH6jcxe6sE9OF6zuJ9+iGHFmVECpjepXq5Nt+ke/P7Rh5qVIpt84KUera lLU+0aTcbnd2m4cR+6SdNWoxYd/7Kewv+miH057XQm29f0IDHv4G80GuPJd77AGd482J a/zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si10611553edb.495.2020.09.22.03.57.41; Tue, 22 Sep 2020 03:58:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726662AbgIVK4c (ORCPT + 99 others); Tue, 22 Sep 2020 06:56:32 -0400 Received: from elvis.franken.de ([193.175.24.41]:51136 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbgIVK4W (ORCPT ); Tue, 22 Sep 2020 06:56:22 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kKfxr-000822-04; Tue, 22 Sep 2020 12:56:03 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 1F9C4C0FFF; Tue, 22 Sep 2020 10:50:49 +0200 (CEST) Date: Tue, 22 Sep 2020 10:50:49 +0200 From: Thomas Bogendoerfer To: Christoph Hellwig Cc: Mauro Carvalho Chehab , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Ben Skeggs , Marek Szyprowski , Tomasz Figa , Matt Porter , iommu@lists.linux-foundation.org, Stefan Richter , linux1394-devel@lists.sourceforge.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 11/18] lib82596: convert to dma_alloc_noncoherent Message-ID: <20200922085049.GE8477@alpha.franken.de> References: <20200915155122.1768241-1-hch@lst.de> <20200915155122.1768241-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915155122.1768241-12-hch@lst.de> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 05:51:15PM +0200, Christoph Hellwig wrote: > Use the new non-coherent DMA API including proper ownership transfers. > This includes moving the DMA helpers to lib82596 based of an ifdef to > avoid include order problems. > > Signed-off-by: Christoph Hellwig > --- > drivers/net/ethernet/i825xx/lasi_82596.c | 25 ++--- > drivers/net/ethernet/i825xx/lib82596.c | 114 ++++++++++++++--------- > drivers/net/ethernet/i825xx/sni_82596.c | 4 - > 3 files changed, 80 insertions(+), 63 deletions(-) Tested-by: Thomas Bogendoerfer (SNI part) -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]