Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3832988pxk; Tue, 22 Sep 2020 03:58:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZs852eCqCOvflLyWyTLhIpe1AdIrKY7Ah8srO0s8DFVV6aMo5EADZSObWA22P5+WjbHsc X-Received: by 2002:a17:906:874f:: with SMTP id hj15mr4408529ejb.539.1600772295548; Tue, 22 Sep 2020 03:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600772295; cv=none; d=google.com; s=arc-20160816; b=UFm80k3uhpOVv2KVykqq9zKc0PSru6lVI0NXCNC6ZlpNDpTwnuwCtOhu54bJOqTjXv +yA5Q9Ld75j4YA8syYKlt4FcF54RrfqXS4s6HcMoosTB5+WU3FNPOTH5NiRp9wLHLjAn Q7ZyhF4fohMZlO0y4nu7cCR8fFOWkRsZC7vImMyImR8aYwzzD7zU5odh2vzKMf7lbzvg V3mUDaZKv8ZLenkhy6yiv8pXajnL1FmlYcwzHflII1W8HXVFLkwMeLFkYJ0f2uQmHjqj GbU1rEnV2GORT5HyVyhMiNNOobRrJkEVLhHvxZASdAL1C1YDBphyOrXwAraoBok0AsAf i6uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=BzfQrhb1n8I3pnVpPAggch1boVQJGD5k2gud0ss2szE=; b=psUPlCcOCLoOYT2VBR4BdvRdLJHRl2rH+pfzEO/WPZ5qfkrxco6NfCpT8naDDd7LbF ocVsVXrlfh4Kxz+cWAz26tkA3VKKvWyVbl6MaOeSxI4riZqKvoApnB2nMoZDQgr/TqKn zl6SDpPXvl1LKssiGjv+5lKC3UB1KWtccY9ZOm76etH18fGOBJ2d1jde+IUWUFkbGEAP Ia9XVDUVsLsn6udOFXVnPphhaIryMgpJuSoHw9JWVFuH5DtvYRo3dOnhsH6gkIj6GJPe GODdWBmeVFpof/wx9wI5+/LzttO0zLnLgrx0dOjiLFC/cjEzB6Nj6iywz8spyHokLIxX rZgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x21si10431722ejb.137.2020.09.22.03.57.52; Tue, 22 Sep 2020 03:58:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbgIVK4l (ORCPT + 99 others); Tue, 22 Sep 2020 06:56:41 -0400 Received: from elvis.franken.de ([193.175.24.41]:51150 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726573AbgIVK43 (ORCPT ); Tue, 22 Sep 2020 06:56:29 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kKfxr-000822-05; Tue, 22 Sep 2020 12:56:03 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 1F289C0FFF; Tue, 22 Sep 2020 10:51:16 +0200 (CEST) Date: Tue, 22 Sep 2020 10:51:16 +0200 From: Thomas Bogendoerfer To: Christoph Hellwig Cc: Mauro Carvalho Chehab , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Ben Skeggs , Marek Szyprowski , Tomasz Figa , Matt Porter , iommu@lists.linux-foundation.org, Stefan Richter , linux1394-devel@lists.sourceforge.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 12/18] sgiseeq: convert to dma_alloc_noncoherent Message-ID: <20200922085116.GF8477@alpha.franken.de> References: <20200915155122.1768241-1-hch@lst.de> <20200915155122.1768241-13-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915155122.1768241-13-hch@lst.de> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 05:51:16PM +0200, Christoph Hellwig wrote: > Use the new non-coherent DMA API including proper ownership transfers. > This includes adding additional calls to dma_sync_desc_dev as the > old syncing was rather ad-hoc. > > Thanks to Thomas Bogendoerfer for debugging the ownership transfer > issues. > > Signed-off-by: Christoph Hellwig > --- > drivers/net/ethernet/seeq/sgiseeq.c | 28 ++++++++++++++++++---------- > 1 file changed, 18 insertions(+), 10 deletions(-) Tested-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]